From: Akhil Goyal <akhil.goyal@nxp.com>
To: Anoob Joseph <anoob.joseph@caviumnetworks.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: "Joseph, Anoob" <Anoob.Joseph@cavium.com>,
"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
"Athreya, Narayana Prasad" <NarayanaPrasad.Athreya@cavium.com>,
"Dwivedi, Ankur" <Ankur.Dwivedi@cavium.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing
Date: Mon, 12 Nov 2018 11:20:31 +0000 [thread overview]
Message-ID: <d331272a-e007-e61d-5725-b849f57067e1@nxp.com> (raw)
In-Reply-To: <1541949837-9629-3-git-send-email-anoob.joseph@caviumnetworks.com>
Hi Anoob,
On 11/11/2018 8:54 PM, Anoob Joseph wrote:
> Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton")
>
> Signed-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>
> ---
> drivers/crypto/octeontx/otx_cryptodev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c
> index 269f045..b201e0a 100644
> --- a/drivers/crypto/octeontx/otx_cryptodev.c
> +++ b/drivers/crypto/octeontx/otx_cryptodev.c
> @@ -100,8 +100,8 @@ otx_cpt_pci_remove(struct rte_pci_device *pci_dev)
> if (rte_eal_process_type() == RTE_PROC_PRIMARY)
> rte_free(cryptodev->data->dev_private);
>
> - cryptodev->device = NULL;
> cryptodev->device->driver = NULL;
> + cryptodev->device = NULL;
> cryptodev->data = NULL;
>
> /* free metapool memory */
Can we squash the entire series into a single patch or at least 2/3 and
3/3 should be merged.
You can have more than one fixes lines in a single patch.
-Akhil
next prev parent reply other threads:[~2018-11-12 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 15:24 [dpdk-dev] [PATCH 0/3] fixing coverity reported issues Anoob Joseph
2018-11-11 15:24 ` [dpdk-dev] [PATCH 1/3] crypto/octeontx: fix non null terminated string Anoob Joseph
2018-11-11 15:24 ` [dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing Anoob Joseph
2018-11-12 11:20 ` Akhil Goyal [this message]
2018-11-12 11:23 ` Joseph, Anoob
2018-11-12 11:45 ` Akhil Goyal
2018-11-11 15:24 ` [dpdk-dev] [PATCH 3/3] " Anoob Joseph
2018-11-12 18:14 ` [dpdk-dev] [PATCH v2] crypto/octeontx: fix coverity issues Anoob Joseph
2018-11-13 10:12 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d331272a-e007-e61d-5725-b849f57067e1@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=Ankur.Dwivedi@cavium.com \
--cc=Anoob.Joseph@cavium.com \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=NarayanaPrasad.Athreya@cavium.com \
--cc=anoob.joseph@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).