From: Nick Connolly <nick.connolly@mayadata.io>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] eal/windows: vfprintf build warning with clang
Date: Sat, 28 Nov 2020 22:46:12 +0000 [thread overview]
Message-ID: <d3865168-9e1a-11ef-6646-09a611ed9d18@mayadata.io> (raw)
In-Reply-To: <20201129001132.2a387aab@sovereign>
Looks good to me!
On 28/11/2020 21:11, Dmitry Kozlyuk wrote:
> On Fri, 27 Nov 2020 12:07:11 +0000, Nick Connolly wrote:
>> [...]
>> +#ifdef __clang__
>> +#pragma clang diagnostic push
>> +#pragma clang diagnostic ignored "-Wformat-nonliteral"
>> +#endif
>> [...]
> How about a more safe approach?
>
> diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windows/eal_lcore.c
> index d5ff721e0..ebcd3474e 100644
> --- a/lib/librte_eal/windows/eal_lcore.c
> +++ b/lib/librte_eal/windows/eal_lcore.c
> @@ -37,6 +37,7 @@ struct cpu_map {
> static struct cpu_map cpu_map = { 0 };
>
> /* eal_create_cpu_map() is called before logging is initialized */
> +__rte_format_printf(1, 2)
> static void
> log_early(const char *format, ...)
> {
next prev parent reply other threads:[~2020-11-28 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 12:07 Nick Connolly
2020-11-28 21:11 ` Dmitry Kozlyuk
2020-11-28 22:46 ` Nick Connolly [this message]
2020-11-29 13:00 ` [dpdk-stable] [PATCH v2] " Nick Connolly
2020-11-29 13:42 ` Dmitry Kozlyuk
2020-12-07 20:25 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2020-12-05 0:41 ` [dpdk-stable] " Kadam, Pallavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3865168-9e1a-11ef-6646-09a611ed9d18@mayadata.io \
--to=nick.connolly@mayadata.io \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).