From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe
Date: Thu, 9 Aug 2018 09:31:36 +0100 [thread overview]
Message-ID: <d3ab4c99-4573-d216-657b-555043713401@intel.com> (raw)
In-Reply-To: <1532399811-52078-1-git-send-email-wei.zhao1@intel.com>
On 7/24/2018 3:36 AM, Wei Zhao wrote:
> There is CRC related ifdefs for ixgbe:
> CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n
> It is used in VF drivers ixgbevf_dev_configure() functions.
> VF cannot change the CRC strip behavior and based on what PF
> configured it needs to response proper to user
> ixgbevf_dev_configure() request. Right now what PF set is
> defined by above config options but this method is too static.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
<...>
> @@ -334,6 +334,7 @@ struct rte_eth_rxmode {
> * structure are allowed to be set.
> */
> uint64_t offloads;
> + uint64_t offloads_disable;
Do we need a disable flag in ethdev, an offload not enabled is disabled by
default isn't it. This conflicts with offloads flag and makes is confusing.
For igb/e1000 VF case, VF driver can't change what PF set and VF driver can't
learn the PF setting dynamically, so this information needs to be passed to VF
driver by application/user.
Currently this information passed by compile time config option, my suggestion
was using devargs.
In your implementation testpmd parameter added to get this information and pass
to driver, but this means all applications needs to do this, instead adding this
support to driver looks better to me.
next prev parent reply other threads:[~2018-08-09 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 2:36 Wei Zhao
2018-08-02 2:27 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2018-08-09 1:51 ` Zhao1, Wei
2018-08-09 8:31 ` Ferruh Yigit [this message]
2018-08-12 6:28 ` [dpdk-stable] " Shahaf Shuler
2018-08-12 7:52 ` Andrew Rybchenko
2018-08-12 8:46 ` Shahaf Shuler
2018-08-13 15:10 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2018-07-24 2:29 Wei Zhao
2018-07-24 8:16 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3ab4c99-4573-d216-657b-555043713401@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).