From: Ferruh Yigit <ferruh.yigit@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/enic: fix uninitialized variable
Date: Wed, 18 Apr 2018 18:09:02 +0100 [thread overview]
Message-ID: <d48d6932-0218-d054-24b7-6e8a11c7166f@intel.com> (raw)
In-Reply-To: <20180418000020.6229-1-johndale@cisco.com>
On 4/18/2018 1:00 AM, John Daley wrote:
> A local variable was used without initialization and triggered a
> coverity issue.
>
> Is is fixed here, but there is no ill effect of not initializing
> the variable in this case. 'rxq_interrupt_offset' is irrelevant
> if 'rxq_interrupt_enable' is not set (the condition caught by
> coverity).
>
> Fixes: fc2c8c0668fd ("net/enic: use Tx completion index instead of messages")
> Coverity issue: 268314
>
> Signed-off-by: John Daley <johndale@cisco.com>
> Reviewed-by: Hyong Youb Kim <hyonkim@cisco.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-04-18 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 23:53 [dpdk-dev] [PATCH] " John Daley
2018-04-18 0:00 ` [dpdk-dev] [PATCH v2] " John Daley
2018-04-18 17:09 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d48d6932-0218-d054-24b7-6e8a11c7166f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).