From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Charles (Chas) Williams" <ciwillia@brocade.com>, dev@dpdk.org
Cc: linville@tuxdriver.com
Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/af_packet: add iface name to internals
Date: Thu, 5 Jan 2017 14:04:38 +0000 [thread overview]
Message-ID: <d4d5c7f6-4700-6cf4-a264-3ec2ff30e280@intel.com> (raw)
In-Reply-To: <1483624424-2806-1-git-send-email-ciwillia@brocade.com>
On 1/5/2017 1:53 PM, Charles (Chas) Williams wrote:
> This will be used by later changes to determine the underlying linux
> interface.
>
> Signed-off-by: Charles (Chas) Williams <ciwillia@brocade.com>
Hi Charles,
Independent from the patch content,
it will be useful if you can send new patchset as reply to previous one,
this way all patches will be in same mail thread, this will help to
trace/review them, also it will be easier to find them in mail archive
in the future.
Another thing is, if you can add a version diff in the comment log,
after "---", that helps others to understand what has been changed in
this new version.
Thanks,
ferruh
<...>
next prev parent reply other threads:[~2017-01-05 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 13:53 Charles (Chas) Williams
2017-01-05 13:53 ` [dpdk-dev] [PATCH v2 2/4] net/af_packet: add support to change mtu Charles (Chas) Williams
2017-01-05 13:53 ` [dpdk-dev] [PATCH v2 3/4] net/af_packet: promisicuous support Charles (Chas) Williams
2017-01-05 13:53 ` [dpdk-dev] [PATCH v2 4/4] net/af_packet: add 802.1Q (VLAN) support Charles (Chas) Williams
2017-01-05 14:04 ` Ferruh Yigit [this message]
2017-01-16 14:31 ` [dpdk-dev] [PATCH v2 1/4] net/af_packet: add iface name to internals Ferruh Yigit
2017-01-16 14:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4d5c7f6-4700-6cf4-a264-3ec2ff30e280@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).