From: "Zhang, Fan" <fanzhang.oss@gmail.com>
To: Akhil Goyal <gakhil@marvell.com>, Kai Ji <kai.ji@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [EXT] [dpdk-dev v6] doc: support IPsec Multi-buffer lib v1.3
Date: Mon, 21 Nov 2022 13:52:36 +0000 [thread overview]
Message-ID: <d4da7884-f0e3-412f-fc7e-414d4ec6bf77@gmail.com> (raw)
In-Reply-To: <CO6PR18MB4484625A8BE37A8AEEAA7910D80A9@CO6PR18MB4484.namprd18.prod.outlook.com>
Hi Akhil,
Agreed. Thanks for clarification.
Regards,
Fan
On 11/21/2022 11:35 AM, Akhil Goyal wrote:
> Hi Fan,
>> Hi Akhil,
>>
>>
>> From 22.11 the ipsec-mb PMDs will be working on two different libraries
>> that may or may not work the same.
>>
>> We also have two different contributor groups working on adding features
>> on top of each library, again one may or may not be compatible to another.
>>
>> I believe there should be some words necessary to distinguish each
>> library support as well as the credits for adding certain features for
>> one platform.
> Ok, but release notes is not a correct place to mention that.
> It should be part of the respective driver documentation.
>
>>
>> On 11/21/2022 6:57 AM, Akhil Goyal wrote:
>>>> diff --git a/doc/guides/rel_notes/release_22_11.rst
>>>> b/doc/guides/rel_notes/release_22_11.rst
>>>> index 4e55b543ef..b98b603fe7 100644
>>>> --- a/doc/guides/rel_notes/release_22_11.rst
>>>> +++ b/doc/guides/rel_notes/release_22_11.rst
>>>> @@ -240,7 +240,16 @@ New Features
>>>>
>>>> * **Updated ipsec_mb crypto driver.**
>>>>
>>>> - Added SNOW-3G and ZUC support for ARM platform.
>>>> + * Added ARM64 port of ipsec-mb library support and SNOW-3G and ZUC
>>>> + support for ARM platform.
>>> You need not update the above line.
>>> * Added SNOW-3G and ZUC support for ARM platform.
>>> Should be good enough.
>>>> + * Added Intel IPsec MB v1.3 library support for x86 platform,
>>>> + see the following guides for more details:
>>>> + :doc:`../cryptodevs/aesni_gcm`
>>>> + :doc:`../cryptodevs/aesni_mb`
>>>> + :doc:`../cryptodevs/chacha20_poly1305`
>>>> + :doc:`../cryptodevs/kasumi`
>>>> + :doc:`../cryptodevs/snow3g`
>>>> + :doc:`../cryptodevs/zuc`
>>> I believe adding reference for each guide is not needed.
>>>
>>> * Added Intel IPsec MB v1.3 library support for x86 platform.
>>> Added details in the guides for all the drivers supported by ipsec_mb.
>> What the guideline Pablo/Kai added here only applies for x86 as
>>
>> a. ARM does not support algorithms other than SNOW3G and ZUC.
> This should be distinguished in the .rst file.
> For release notes, above thing is sufficient.
>
>> b. The performance guideline may not apply to ARM.
> Again, it should be part of driver documentation and not release notes.
>
> And for each of the release note bullet that I suggested are mentioning the
> Platform on which the support is added.
>
>
next prev parent reply other threads:[~2022-11-21 13:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 18:33 [PATCH] " Pablo de Lara
2022-11-09 18:39 ` [PATCH v2] " Pablo de Lara
2022-11-10 9:38 ` [EXT] " Akhil Goyal
2022-11-10 10:43 ` Power, Ciara
2022-11-10 11:07 ` [PATCH v3] " Pablo de Lara
2022-11-10 11:17 ` Dooley, Brian
2022-11-10 11:39 ` Ji, Kai
2022-11-11 16:24 ` De Lara Guarch, Pablo
2022-11-10 16:44 ` Zhang, Fan
2022-11-12 11:26 ` [PATCH v4] " Pablo de Lara
2022-11-14 23:34 ` Ji, Kai
2022-11-15 9:24 ` Akhil Goyal
2022-11-15 17:11 ` [dpdk-dev v5] " Kai Ji
2022-11-15 20:17 ` Zhang, Fan
2022-11-16 12:06 ` [dpdk-dev v6] " Kai Ji
2022-11-17 12:16 ` Kai Ji
2022-11-21 6:57 ` [EXT] " Akhil Goyal
2022-11-21 10:57 ` Zhang, Fan
2022-11-21 11:35 ` Akhil Goyal
2022-11-21 13:52 ` Zhang, Fan [this message]
2022-11-21 16:35 ` [dpdk-dev v7] " Kai Ji
2022-11-22 11:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4da7884-f0e3-412f-fc7e-414d4ec6bf77@gmail.com \
--to=fanzhang.oss@gmail.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=kai.ji@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).