From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Michael Baum <michaelba@nvidia.com>, <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH v2 5/5] doc: update doorbell mapping parameter name in mlx5 guide
Date: Wed, 23 Feb 2022 21:48:05 +0000 [thread overview]
Message-ID: <d569bb90-7dd9-810b-064e-ec8ab62a2e59@intel.com> (raw)
In-Reply-To: <20220223134834.2840916-6-michaelba@nvidia.com>
On 2/23/2022 1:48 PM, Michael Baum wrote:
> The "tx_db_nc" devarg forces doorbell register mapping to non-cached
> region eliminating the extra write memory barrier. This argument was
> used in creating the UAR for Tx and thus affected its performance.
>
> Recently [1] its use has been extended to all UAR creation in all mlx5
> drivers, and now its name is no longer so accurate.
>
> This patch changes its name to "sq_db_nc" to suit any send queue that
> uses it. The old name will still work for backward compatibility.
>
> [1] commit 5dfa003db53f ("common/mlx5: fix post doorbell barrier")
>
> Signed-off-by: Michael Baum<michaelba@nvidia.com>
> Reviewed-by: Raslan Darawsheh<rasland@nvidia.com>
> Acked-by: Viacheslav Ovsiienko<viacheslavo@nvidia.com>
> ---
> doc/guides/nics/mlx5.rst | 34 ++-----------------
> doc/guides/platform/mlx5.rst | 39 ++++++++++++++++++++++
> drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-
> drivers/common/mlx5/mlx5_common.c | 31 ++++++++++++-----
> drivers/common/mlx5/mlx5_common_defs.h | 8 ++---
> drivers/net/mlx5/linux/mlx5_verbs.c | 2 +-
> drivers/net/mlx5/mlx5_devx.c | 2 +-
> 7 files changed, 72 insertions(+), 46 deletions(-)
Hi Michael,
This is not a document patch to update the parameter name,
patch actually changes the parameter name in the code and
documents it, updating it as:
net/mlx5: update doorbell mapping parameter name
next prev parent reply other threads:[~2022-02-23 21:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 12:48 [PATCH 0/5] refactore mlx5 guides Michael Baum
2022-02-22 12:48 ` [PATCH 1/5] doc: remove obsolete explanations from mlx5 guide Michael Baum
2022-02-22 12:48 ` [PATCH 2/5] doc: replace broken links in " Michael Baum
2022-02-22 12:48 ` [PATCH 3/5] doc: correct name of BlueField-2 " Michael Baum
2022-02-22 12:48 ` [PATCH 4/5] doc: add shared guide for mlx5 PMDs Michael Baum
2022-02-22 12:48 ` [PATCH 5/5] doc: update doorbell mapping parameter name in mlx5 guide Michael Baum
2022-02-22 14:43 ` [PATCH 0/5] refactore mlx5 guides Raslan Darawsheh
2022-02-23 13:48 ` [PATCH v2 0/5] Refactor " Michael Baum
2022-02-23 13:48 ` [PATCH v2 1/5] doc: remove obsolete explanations from mlx5 guide Michael Baum
2022-02-23 13:48 ` [PATCH v2 2/5] doc: replace broken links in " Michael Baum
2022-02-23 13:48 ` [PATCH v2 3/5] doc: correct name of BlueField-2 " Michael Baum
2022-02-23 13:48 ` [PATCH v2 4/5] doc: add shared guide for mlx5 PMDs Michael Baum
2022-02-23 13:48 ` [PATCH v2 5/5] doc: update doorbell mapping parameter name in mlx5 guide Michael Baum
2022-02-23 21:48 ` Ferruh Yigit [this message]
2022-02-25 0:01 ` Michael Baum
2022-02-25 10:21 ` Ferruh Yigit
2022-02-23 14:35 ` [PATCH v2 0/5] Refactor mlx5 guides Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d569bb90-7dd9-810b-064e-ec8ab62a2e59@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).