From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matej Vido <vido@cesnet.cz>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported firmwares
Date: Wed, 31 May 2017 10:11:40 +0100 [thread overview]
Message-ID: <d5dbc629-b534-b280-ca4c-c3ad4b2db1eb@intel.com> (raw)
In-Reply-To: <88d126a8-1575-c478-2810-d5dec0f9a96f@cesnet.cz>
On 5/31/2017 9:34 AM, Matej Vido wrote:
> On 29.05.2017 14:42, Ferruh Yigit wrote:
>> On 5/26/2017 7:05 PM, Matej Vido wrote:
>>> Add IBUF and OBUF offsets definitions for new firmwares.
>> just to double check, is it required to add new pci device ids to
>> support these new cards?
>>
>> Is dpdk supported nics (http://dpdk.org/doc/nics) needs to be updated?
>>
>> Can you please update release notes to announce new cards support?
> Hi Ferruh,
>
> This patch set adds mainly the support of new firmwares for the cards
> that are already supported.
> But you are right, there is also one new card which would need to add
> new pci device id. We have to check if we want to add the card in this
> patch set and I will update v2 accordingly.
>
>>
>>> Signed-off-by: Matej Vido <vido@cesnet.cz>
>> <...>
>>
>>> +#elif RTE_LIBRTE_PMD_SZEDATA2_AS == 5
>>> +
>>> +const uint32_t szedata2_ibuf_base_table[] = {
>>> + 0x8000,
>>> + 0x8200,
>>> + 0x8400,
>>> + 0x8600,
>>> + 0x8800
>>> +};
>>> +const uint32_t szedata2_obuf_base_table[] = {
>>> + 0x9000,
>>> + 0x9200,
>>> + 0x9400,
>>> + 0x9600,
>>> + 0x9800
>>> +};
>> AS = 5 is not documented in both documentation and source code comment,
>> can you please add this one too?
> 5 is for future use and experimental firmwares. Would it make sense to
> write this note in the comments but not in the documentation to avoid
> confusion or should it be mentioned in the documentation too?
I think it is good to mention in documentation, since this will be part
of released code, but this can be brief.
>
> Thanks,
> Matej
>>> +
>>> #else
>>> #error "RTE_LIBRTE_PMD_SZEDATA2_AS has wrong value, see comments in config file"
>>> #endif
>>>
>
next prev parent reply other threads:[~2017-05-31 9:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 18:05 [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf names Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 2/5] net/szedata2: refactor ibuf and obuf read and write Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 3/5] net/szedata2: refactor ibuf and obuf address definition Matej Vido
2017-05-29 12:41 ` Ferruh Yigit
2017-05-31 8:33 ` Matej Vido
2017-05-31 9:12 ` Ferruh Yigit
2017-05-26 18:05 ` [dpdk-dev] [PATCH 4/5] net/szedata2: move ibuf and obuf to specific header Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported firmwares Matej Vido
2017-05-29 12:42 ` Ferruh Yigit
2017-05-31 8:34 ` Matej Vido
2017-05-31 9:11 ` Ferruh Yigit [this message]
2017-05-29 12:40 ` [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf names Ferruh Yigit
2017-05-31 8:32 ` Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 " Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 2/5] net/szedata2: refactor ibuf and obuf read and write Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 3/5] net/szedata2: refactor ibuf and obuf address definition Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 4/5] net/szedata2: move ibuf and obuf to specific header Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 5/5] net/szedata2: add more supported firmwares Matej Vido
2017-06-12 14:35 ` [dpdk-dev] [PATCH v2 1/5] net/szedata2: refactor ibuf and obuf names Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5dbc629-b534-b280-ca4c-c3ad4b2db1eb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=vido@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).