From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <anatoly.burakov@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fslmc bus need vfio enabled for non PCI case as well
Date: Sat, 7 Oct 2017 16:52:06 +0530 [thread overview]
Message-ID: <d65cb18e-9e69-e0a6-56d9-14df750ff690@nxp.com> (raw)
In-Reply-To: <3872801.Digd9JTyXe@xps>
On 10/6/2017 10:38 PM, Thomas Monjalon wrote:
> 06/10/2017 18:22, Hemant Agrawal:
>> On 10/6/2017 5:11 AM, Thomas Monjalon wrote:
>>> 13/07/2017 13:48, Hemant Agrawal:
>>>> In case no_pci is configured, fslmc bus will still need the
>>>> the vfio to be enabled.
>>>>
>>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>> ---
>>>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>>>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>>>> +#ifdef RTE_LIBRTE_FSLMC_BUS
>>>> + if (!vfio_enabled) {
>>>> + if (!vfio_enable("vfio_fsl_mc"))
>>>> + vfio_enabled = 1;
>>>> + }
>>>> +#endif
>>>
>>> It seems to be a hack.
>>> VFIO is not only PCI.
>>> Why --no-pci is impacting VFIO?
>>>
>>> Anatoly?
>>>
>>
>> At present there are only 2 users of VFIO. PCI and fsl-mc bus.
>>
>>
>> One options is that we always enable vfio irrespective of --no-pci flag.
>> My believe is that vfio-pci will be present in most system supporting
>> any other flavor of vfio (platform, fsl-mc etc).
>>
>> The other option is what I proposed. i.e. if vfio is not already enabled
>> the platform is FSLMC bus, enable it.
>
> Why not always enable it?
>
I agree. sent a v2 for this.
Regards,
Hemant
next prev parent reply other threads:[~2017-10-07 11:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 11:48 Hemant Agrawal
2017-10-05 23:41 ` Thomas Monjalon
2017-10-06 16:22 ` Hemant Agrawal
2017-10-06 17:08 ` Thomas Monjalon
2017-10-07 11:22 ` Hemant Agrawal [this message]
2017-10-07 11:20 ` [dpdk-dev] [PATCH v2] eal: enable vfio independent of no PCI flag Hemant Agrawal
2017-10-07 11:37 ` Thomas Monjalon
2017-10-10 13:46 ` Hemant Agrawal
2017-10-10 16:27 ` Thomas Monjalon
2017-10-11 6:42 ` [dpdk-dev] [PATCH v3] eal: enable vfio independent of PCI bus Hemant Agrawal
2017-10-23 6:33 ` [dpdk-dev] FW: " Hemant Agrawal
2017-10-23 11:00 ` Burakov, Anatoly
2017-10-23 11:47 ` [dpdk-dev] " Burakov, Anatoly
2017-10-23 22:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d65cb18e-9e69-e0a6-56d9-14df750ff690@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).