From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"Yang, Zhiyong" <zhiyong.yang@intel.com>,
"ktraynor@redhat.com" <ktraynor@redhat.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark
Date: Tue, 20 Dec 2016 15:54:46 +0100 [thread overview]
Message-ID: <d6a9f7ab-f2a5-ba02-db5e-d8454a7029f8@redhat.com> (raw)
In-Reply-To: <15125480.nLCo42mjm8@xps13>
On 12/20/2016 11:03 AM, Thomas Monjalon wrote:
>>>>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>>
>>>> There is one trailing whitespace warning but apart from that:
>>>>
>>>> Acked-by: John McNamara <john.mcnamara@intel.com>
>>>
>>> Thanks John,
>>>
>>> Do you want me to send a v3, fixing the trailing whitespace & collecting
>>> the acks?
>>
>> No need (unless the tree maintainer says otherwise).
>> It was one trailing whitespace. Just something to look out for in future.
>
> Removed when applying.
> Fixed some heading issues also:
>
> --- a/doc/guides/howto/pvp_reference_benchmark.rst
> +++ b/doc/guides/howto/pvp_reference_benchmark.rst
> @@ -160,7 +160,7 @@ Testpmd launch
> --portmask=f --disable-hw-vlan -i --rxq=1 --txq=1
> --nb-cores=4 --forward-mode=io
>
> -With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
> + With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
>
> #. In testpmd interactive mode, set the portlist to obtain the correct port
> chaining:
> @@ -176,7 +176,8 @@ VM launch
>
> The VM may be launched either by calling QEMU directly, or by using libvirt.
>
> -#. Qemu way:
> +Qemu way
> +^^^^^^^^
>
> Launch QEMU with two Virtio-net devices paired to the vhost-user sockets
> created by testpmd. Below example uses default Virtio-net options, but options
> @@ -210,7 +211,8 @@ where isolated CPUs 6 and 7 will be used as lcores for Virtio PMDs:
> export PYTHONPATH=$PYTHONPATH:<QEMU path>/scripts/qmp
> ./qmp-vcpu-pin -s /tmp/qmp.socket 1 6 7
>
> -#. Libvirt way:
> +Libvirt way
> +^^^^^^^^^^^
>
> Some initial steps are required for libvirt to be able to connect to testpmd's
> sockets.
Thanks Thomas for handling these fixes.
Maxime
prev parent reply other threads:[~2016-12-20 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 12:24 Maxime Coquelin
2016-12-07 9:39 ` Yuanhan Liu
2016-12-07 12:51 ` Kevin Traynor
2016-12-07 21:07 ` Mcnamara, John
2016-12-09 6:29 ` Maxime Coquelin
2016-12-09 10:26 ` Mcnamara, John
2016-12-20 10:03 ` Thomas Monjalon
2016-12-20 14:54 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a9f7ab-f2a5-ba02-db5e-d8454a7029f8@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=ktraynor@redhat.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).