From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Shepard Siegel <shepard.siegel@atomicrules.com>,
Ed Czeck <ed.czeck@atomicrules.com>,
John Miller <john.miller@atomicrules.com>,
John McNamara <john.mcnamara@intel.com>,
Harish Patil <harish.patil@cavium.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Jing Chen <jing.d.chen@intel.com>,
Helin Zhang <helin.zhang@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
Matej Vido <vido@cesnet.cz>,
Pascal Mazon <pascal.mazon@6wind.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Shrikrishna Khare <skhare@vmware.com>
Subject: Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature
Date: Mon, 15 May 2017 09:40:20 +0100 [thread overview]
Message-ID: <d6b460e1-e9d3-831d-7a06-42cedc5cf50e@intel.com> (raw)
In-Reply-To: <17406199.hqjMraK9H2@xps>
On 5/12/2017 4:48 PM, Thomas Monjalon wrote:
> 12/05/2017 12:49, Ferruh Yigit:
>> On 5/10/2017 2:51 PM, Thomas Monjalon wrote:
>>> 10/05/2017 15:10, Ferruh Yigit:
>>>> --- a/doc/guides/nics/features/bnx2x.ini
>>>> +++ b/doc/guides/nics/features/bnx2x.ini
>>>> @@ -4,6 +4,7 @@
>>>> ; Refer to default.ini for the full list of available PMD features.
>>>> ;
>>>> [Features]
>>>> +Speed capabilities = Y
>>>
>>> We should validate this feature only if the driver advertise the
>>> right speeds for the device.
>>
>> Hi Thomas,
>>
>> Can you please clarify more, what is expected implementation in PMD?
>
> It is expected to advertise only the speeds that the device is
> capable to offer.
>
>> And perhaps a good and a bad sample can be helpful.
>
> Good example:
> drivers/net/i40e/i40e_ethdev.c
> if (I40E_PHY_TYPE_SUPPORT_40G(hw->phy.phy_types))
> /* For XL710 */
> dev_info->speed_capa = ETH_LINK_SPEED_40G;
> else if (I40E_PHY_TYPE_SUPPORT_25G(hw->phy.phy_types))
> /* For XXV710 */
> dev_info->speed_capa = ETH_LINK_SPEED_25G;
> else
> /* For X710 */
> dev_info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G;
>
> Bad example:
> drivers/net/bnx2x/bnx2x_ethdev.c
> dev_info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_20G;
> Looking at qlogic.com, only some 57840 adapters are capable of 20G.
OK, I will update the patch according.
Does it make sense to mark PMDs that report speed_capabilities, but
without checking actual hw, as partial "P", to differentiate them from
the ones that doesn't report at all, also this may help to PMD
maintainers about what to fix.
Thanks,
ferruh
next prev parent reply other threads:[~2017-05-15 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 13:10 Ferruh Yigit
2017-05-10 13:49 ` Mcnamara, John
2017-05-10 13:51 ` Thomas Monjalon
2017-05-12 10:49 ` Ferruh Yigit
2017-05-12 15:48 ` Thomas Monjalon
2017-05-15 8:40 ` Ferruh Yigit [this message]
2017-05-15 9:33 ` Thomas Monjalon
2017-05-16 9:39 ` Alejandro Lucero
2017-05-16 10:02 ` Thomas Monjalon
2017-05-16 10:17 ` Alejandro Lucero
2017-05-15 10:59 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2017-05-15 12:17 ` Pascal Mazon
2017-05-15 12:23 ` Ferruh Yigit
2017-05-15 12:30 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2017-05-17 13:28 ` Mcnamara, John
2017-06-12 15:48 ` Ferruh Yigit
2017-05-16 9:00 ` [dpdk-dev] [PATCH v2] " Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b460e1-e9d3-831d-7a06-42cedc5cf50e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=harish.patil@cavium.com \
--cc=helin.zhang@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jing.d.chen@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=john.miller@atomicrules.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=pascal.mazon@6wind.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=shepard.siegel@atomicrules.com \
--cc=shreyansh.jain@nxp.com \
--cc=skhare@vmware.com \
--cc=thomas@monjalon.net \
--cc=vido@cesnet.cz \
--cc=wenzhuo.lu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).