From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: fix multiple queue not being enabled for older kernels
Date: Wed, 1 Mar 2017 09:16:04 +0100 [thread overview]
Message-ID: <d6b4f181-857c-1aca-e638-73b6a2841ec7@redhat.com> (raw)
In-Reply-To: <1487839550-21800-1-git-send-email-yuanhan.liu@linux.intel.com>
On 02/23/2017 09:45 AM, Yuanhan Liu wrote:
> Some macros (say VIRTIO_NET_F_MQ) are needed for enabling multiple queue,
> however they are introduced since kernel v3.8, meaning build error happens
> if we build DPDK vhost on those platforms.
>
> 71dfdbe66a66 ("vhost: fix build with kernel < 3.8") meant to fix it, but
> in a wrong way: it completely disables the MQ features for those kernels.
> However, the MQ feature doesn't depend on the kernel at all (except the
> macros dependency stated above), that we could still enable the MQ feature
> even the host kernel has no such support.
>
> The right fix is to define the macro if it's not defined.
>
> Fixes: 71dfdbe66a66 ("vhost: fix build with kernel < 3.8")
>
> Cc: stable@dpdk.org
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
> lib/librte_vhost/vhost.c | 2 +-
> lib/librte_vhost/vhost.h | 11 ++++-------
> lib/librte_vhost/vhost_user.c | 2 +-
> 3 files changed, 6 insertions(+), 9 deletions(-)
>
Agree this is the right fix:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks!
Maxime
next prev parent reply other threads:[~2017-03-01 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 8:45 Yuanhan Liu
2017-03-01 8:16 ` Maxime Coquelin [this message]
2017-03-01 10:41 ` [dpdk-stable] [PATCH v2 1/2] " Yuanhan Liu
2017-03-01 10:41 ` [dpdk-stable] [PATCH v2 2/2] vhost: fix max queues Yuanhan Liu
2017-03-22 8:36 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b4f181-857c-1aca-e638-73b6a2841ec7@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).