From: "Hunt, David" <david.hunt@intel.com>
To: Harry van Haaren <harry.van.haaren@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] event/sw: fix credit return on invalid queue id
Date: Tue, 18 Apr 2017 11:11:31 +0100 [thread overview]
Message-ID: <d71a534e-adc8-3593-cbc3-0290592dbce9@intel.com> (raw)
In-Reply-To: <1492509520-31943-1-git-send-email-harry.van.haaren@intel.com>
On 18/4/2017 10:58 AM, Harry van Haaren wrote:
> This patch returns a credit when an rte_event is
> enqueued with an invalid queue_id. Previously a
> credit was leaked from the system.
>
> Note that the eventdev instance does not attempt
> to free any resources that the rte_event owns. As
> a result, resources owned by the rte_event are leaked.
> Eg. if the rte_event represents an rte_mbuf, the mbuf
> will not be freed, and causes a leak from the mempool.
>
> Fixes: 656af9180014 ("event/sw: add worker core functions")
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> drivers/event/sw/sw_evdev_worker.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/event/sw/sw_evdev_worker.c b/drivers/event/sw/sw_evdev_worker.c
> index b9b6f8d..9cb6bef 100644
> --- a/drivers/event/sw/sw_evdev_worker.c
> +++ b/drivers/event/sw/sw_evdev_worker.c
> @@ -105,9 +105,12 @@ sw_event_enqueue_burst(void *port, const struct rte_event ev[], uint16_t num)
> */
> if ((new_ops[i] & QE_FLAG_COMPLETE) && outstanding)
> p->outstanding_releases--;
> - /* Branch to avoid touching p->stats except error case */
> - if (unlikely(invalid_qid))
> +
> + /* error case: branch to avoid touching p->stats */
> + if (unlikely(invalid_qid)) {
> p->stats.rx_dropped++;
> + p->inflight_credits++;
> + }
> }
>
> /* returns number of events actually enqueued */
Acked-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2017-04-18 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 9:58 Harry van Haaren
2017-04-18 10:11 ` Hunt, David [this message]
2017-04-19 22:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d71a534e-adc8-3593-cbc3-0290592dbce9@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).