From: "Doherty, Declan" <declan.doherty@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
zengganghui <zengganghui@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets
Date: Tue, 10 Oct 2017 09:53:22 +0100 [thread overview]
Message-ID: <d71b4823-1393-ab1f-1cb2-d8f8e8c12e62@intel.com> (raw)
In-Reply-To: <972b7ffc-8eb4-86e3-5e80-a57025c00407@intel.com>
On 03/10/2017 4:49 PM, Ferruh Yigit wrote:
> On 9/19/2017 5:09 AM, zengganghui wrote:
>> Local LACP packets do not have VLANs, and ethertype must be ETHER_TYPE_SLOW. But when the PMD supports VLAN strip, you cannot directly determine the ethertype from the packet, but depends on whether the VLAN is stripped. If a VLAN is stripped, then this is not a local LACP packet, but it may be a need to pass through packet. The previous code was not rigorous in determining whether the VLAN was being stripped.
>> Did I answer your question?
>
> Hi Declan,
>
> Are you OK with the patch?
> You already have your ack on patch but discussion was going on...
>
>
...
>
Hey Ferruh, sorry I missed this mail, yes I'm happy for this to be applied.
next prev parent reply other threads:[~2017-10-10 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 3:46 ZengGanghui
2017-09-04 13:19 ` Radu Nicolau
2017-10-10 19:55 ` Ferruh Yigit
2017-09-18 9:14 ` Doherty, Declan
2017-09-18 11:12 ` zengganghui
2017-09-18 12:33 ` Doherty, Declan
2017-09-18 12:50 ` zengganghui
2017-09-18 13:11 ` Doherty, Declan
2017-09-19 4:09 ` zengganghui
2017-10-03 15:49 ` Ferruh Yigit
2017-10-10 8:53 ` Doherty, Declan [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-30 3:43 ZengGanghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d71b4823-1393-ab1f-1cb2-d8f8e8c12e62@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=zengganghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).