From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized
Date: Thu, 13 Apr 2017 15:39:34 +0800 [thread overview]
Message-ID: <d7a27459-fe47-63eb-8963-e8c0c554d418@intel.com> (raw)
In-Reply-To: <20170413023623.GH7333@yliu-dev.sh.intel.com>
On 4/13/2017 10:36 AM, Yuanhan Liu wrote:
> On Thu, Apr 13, 2017 at 10:18:43AM +0800, Tan, Jianfeng wrote:
>>
>> On 4/13/2017 9:58 AM, Yuanhan Liu wrote:
>>> On Fri, Apr 07, 2017 at 07:57:40AM +0000, Jianfeng Tan wrote:
>>>> After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled
>>>> by default.
> Actually, that's my point. The vhost lib just claim he supports MTU
> feature and MTU is not enabled by the virtio-user device. Meaning,
> the MTU feature bit should not be set after the negoitation.
>
> You were seeing the bug because you found the bit is set, right?
> If so, that means the virtio-user feature negotiation is broken.
Make sense. Then I'll use a macro to define all supported features by
virtio-user as a filter, so that any new features will be disabled in
virtio-user.
Thanks,
Jianfeng
next prev parent reply other threads:[~2017-04-13 7:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 7:57 Jianfeng Tan
2017-04-13 1:58 ` Yuanhan Liu
2017-04-13 2:18 ` Tan, Jianfeng
2017-04-13 2:21 ` Yuanhan Liu
2017-04-13 7:37 ` Tan, Jianfeng
2017-04-13 2:36 ` Yuanhan Liu
2017-04-13 7:39 ` Tan, Jianfeng [this message]
2017-04-13 10:11 ` [dpdk-dev] [PATCH v2] " Jianfeng Tan
2017-04-14 4:24 ` Yuanhan Liu
2017-04-14 4:35 ` Tan, Jianfeng
2017-04-14 5:37 ` Yuanhan Liu
2017-04-14 5:55 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7a27459-fe47-63eb-8963-e8c0c554d418@intel.com \
--to=jianfeng.tan@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).