From: David Hunt <david.hunt@intel.com>
To: Richael Zhuang <richael.zhuang@arm.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3 1/1] power: check freq count before filling the freqs array
Date: Fri, 23 Jul 2021 09:37:56 +0100 [thread overview]
Message-ID: <d7d2ee14-8f18-6e66-a7e8-a9bfacdff5d3@intel.com> (raw)
In-Reply-To: <20210723022242.8092-2-richael.zhuang@arm.com>
Hi Richael,
On 23/7/2021 3:22 AM, Richael Zhuang wrote:
> The freqs array size is RTE_MAX_LCORE_FREQS. Before filling the
> array with num_freqs elements, restrict the total num to
> RTE_MAX_LCORE_FREQS. This fix aims to fix the coverity scan issue
> like:
> Overrunning array "pi->freqs" of 256 bytes by passing it to a
> function which accesses it at byte offset 464.
>
> Coverity issue: 371913
> Fixes: ef1cc88f1837 ("power: support cppc_cpufreq driver")
> Cc: richael.zhuang@arm.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
> ---
> lib/power/power_cppc_cpufreq.c | 5 +++++
> lib/power/power_pstate_cpufreq.c | 5 +++++
> 2 files changed, 10 insertions(+)
>
---snip---
LGTM to fix the coverity issue.
Acked-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2021-07-23 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210721092750.13202-2-richael.zhuang@arm.com>
[not found] ` <20210723021313.7085-1-richael.zhuang@arm.com>
2021-07-23 2:13 ` [dpdk-stable] [PATCH v2 " Richael Zhuang
[not found] ` <20210723022242.8092-1-richael.zhuang@arm.com>
2021-07-23 2:22 ` [dpdk-stable] [PATCH v3 " Richael Zhuang
2021-07-23 8:37 ` David Hunt [this message]
2021-07-24 8:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d2ee14-8f18-6e66-a7e8-a9bfacdff5d3@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=richael.zhuang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).