From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, changpeng.liu@intel.com, tiwei.bie@intel.com,
i.maximets@samsung.com
Subject: Re: [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend
Date: Thu, 28 Feb 2019 17:56:55 +0100 [thread overview]
Message-ID: <d7d38092-91ce-efff-541e-ff088e253185@redhat.com> (raw)
In-Reply-To: <20190228153134.31865-3-maxime.coquelin@redhat.com>
On 2/28/19 4:31 PM, Maxime Coquelin wrote:
> + handled = false;
> if (dev->extern_ops.pre_msg_handle) {
> ret = (*dev->extern_ops.pre_msg_handle)(dev->vid,
> - (void *)&msg, &skip_master);
> - if (ret == RTE_VHOST_MSG_RESULT_ERR)
> - goto skip_to_reply;
> - else if (ret == RTE_VHOST_MSG_RESULT_REPLY)
> + (void *)&msg);
> + switch (ret) {
> + case RTE_VHOST_MSG_RESULT_REPLY:
Note that I missed to add "/* Fall-through */" so that it builds with
newer GCCs.
That will be fixed in v1.
> send_vhost_reply(fd, &msg);
> -
> - if (skip_master)
> + case RTE_VHOST_MSG_RESULT_ERR:
> + case RTE_VHOST_MSG_RESULT_OK:
> + handled = true;
> goto skip_to_post_handle;
> + case RTE_VHOST_MSG_RESULT_NOT_HANDLED:
> + default:
> + break;
> + }
next prev parent reply other threads:[~2019-02-28 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 15:31 [dpdk-dev] [RFC v2 0/2] vhost: Support external backend only vhost-user requests Maxime Coquelin
2019-02-28 15:31 ` [dpdk-dev] [RFC v2 1/2] vhost: add API to set protocol features flags Maxime Coquelin
2019-03-08 9:13 ` Stojaczyk, Dariusz
2019-02-28 15:31 ` [dpdk-dev] [RFC v2 2/2] vhost: support requests only handled by external backend Maxime Coquelin
2019-02-28 16:56 ` Maxime Coquelin [this message]
2019-03-04 15:25 ` Ilya Maximets
2019-03-04 16:02 ` Maxime Coquelin
2019-03-04 16:24 ` Ilya Maximets
2019-03-08 9:18 ` Stojaczyk, Dariusz
2019-03-08 10:01 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d38092-91ce-efff-541e-ff088e253185@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=changpeng.liu@intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).