From: "David Harton (dharton)" <dharton@cisco.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5] ethdev: add return code to rte_eth_stats_reset()
Date: Wed, 20 Sep 2017 14:01:23 +0000 [thread overview]
Message-ID: <d81f8311e74c4605b693b3e0813946f7@XCH-RCD-016.cisco.com> (raw)
In-Reply-To: <f1c152d3-f8ca-f7f9-4ada-be2b1bd3ece1@intel.com>
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>
> On 9/1/2017 3:26 AM, David Harton wrote:
> > Some devices do not support reset of eth stats. An application may
> > need to know not to clear shadow stats if the device cannot.
> >
> > rte_eth_stats_reset is updated to provide a return code to share
> > whether the device supports reset or not.
> >
> > Signed-off-by: David Harton <dharton@cisco.com>
> > ---
> >
> > v5:
> > * squashed doc patch
> > * moved rel_note change from ABI to API section
> >
> > v4:
> > * commented return values
> >
> > v3:
> > * overcame noob errors and figured out patch challenged
> >
> > v2:
> > * fixed soft tab issue inserted while moving changes
> >
> > doc/guides/rel_notes/release_17_11.rst | 13 +++++++++++++
> > lib/librte_ether/rte_ethdev.c | 8 +++++---
> > lib/librte_ether/rte_ethdev.h | 6 +++++-
> > 3 files changed, 23 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/release_17_11.rst
> > b/doc/guides/rel_notes/release_17_11.rst
> > index 22df4fd..6282667 100644
> > --- a/doc/guides/rel_notes/release_17_11.rst
> > +++ b/doc/guides/rel_notes/release_17_11.rst
> > @@ -110,6 +110,19 @@ API Changes
> > Also, make sure to start the actual text at the margin.
> > =========================================================
> >
> > +* **Modified the return type of rte_eth_stats_reset.**
> > +
> > + Changed return type of ``rte_eth_stats_reset`` from ``void`` to
> > + ``int`` so the caller may know whether a device supports the
> > + operation or not and if the operation was carried out.
> > +
>
> > +* **Modified the vlan_offload_set_t function prototype in the ethdev
> > +library.**
> > +
> > + Changed the function prototype of ``vlan_offload_set_t``. The
> > + return value has been changed from ``void`` to ``int`` so the
> > + caller to knows whether the backing device supports the operation
> > + or if the operation was successfully performed.
> > +
>
> Is this addition to the document related to this patch?
Good catch. No. :(
I must have mishandled the rebase I did to update this patch. V6 coming.
Would be great if you could re-ACK afterwards so this one can move.
Thanks,
Dave
>
> > * **Modified the vlan_offload_set_t function prototype in the ethdev
> > library.**
> >
> > Changed the function prototype of ``vlan_offload_set_t``. The
> > return value diff --git a/lib/librte_ether/rte_ethdev.c
> > b/lib/librte_ether/rte_ethdev.c index 05e52b8..f0f1775 100644
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> > @@ -1341,17 +1341,19 @@ struct rte_eth_dev *
> > return 0;
> > }
> >
> > -void
> > +int
> > rte_eth_stats_reset(uint8_t port_id)
> > {
> > struct rte_eth_dev *dev;
> >
> > - RTE_ETH_VALID_PORTID_OR_RET(port_id);
> > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
> > dev = &rte_eth_devices[port_id];
> >
> > - RTE_FUNC_PTR_OR_RET(*dev->dev_ops->stats_reset);
> > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->stats_reset, -ENOTSUP);
> > (*dev->dev_ops->stats_reset)(dev);
> > dev->data->rx_mbuf_alloc_failed = 0;
> > +
> > + return 0;
> > }
> >
> > static int
> > diff --git a/lib/librte_ether/rte_ethdev.h
> > b/lib/librte_ether/rte_ethdev.h index 7254fd0..9110725 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -2246,8 +2246,12 @@ int rte_eth_tx_queue_setup(uint8_t port_id,
> uint16_t tx_queue_id,
> > *
> > * @param port_id
> > * The port identifier of the Ethernet device.
> > + * @return
> > + * - (0) if device notified to reset stats.
> > + * - (-ENOTSUP) if hardware doesn't support.
> > + * - (-ENODEV) if *port_id* invalid.
> > */
> > -void rte_eth_stats_reset(uint8_t port_id);
> > +int rte_eth_stats_reset(uint8_t port_id);
> >
> > /**
> > * Retrieve names of extended statistics of an Ethernet device.
> >
next prev parent reply other threads:[~2017-09-20 14:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 17:39 [dpdk-dev] [PATCH v3] " David Harton
2017-08-08 9:02 ` Van Haaren, Harry
2017-08-08 11:01 ` David Harton (dharton)
2017-08-08 11:03 ` Christian Ehrhardt
2017-08-08 13:13 ` Thomas Monjalon
2017-08-10 13:29 ` [dpdk-dev] [PATCH v4 1/2] " David Harton
2017-08-10 13:29 ` [dpdk-dev] [PATCH v4 2/2] doc: Update ABI Change for rte_eth_stats_reset David Harton
2017-08-31 22:10 ` Thomas Monjalon
2017-08-31 22:10 ` Thomas Monjalon
2017-08-31 22:16 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add return code to rte_eth_stats_reset() Thomas Monjalon
2017-09-01 2:26 ` [dpdk-dev] [PATCH v5] " David Harton
2017-09-01 7:47 ` Hemant Agrawal
2017-09-19 17:14 ` Ferruh Yigit
2017-09-20 14:01 ` David Harton (dharton) [this message]
2017-09-20 16:55 ` Ferruh Yigit
2017-09-20 14:11 ` [dpdk-dev] [PATCH v6] " David C Harton
2017-09-20 16:56 ` Ferruh Yigit
2017-10-09 23:02 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d81f8311e74c4605b693b3e0813946f7@XCH-RCD-016.cisco.com \
--to=dharton@cisco.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).