From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: print Rx/Tx offload values
Date: Fri, 9 Mar 2018 18:27:13 +0000 [thread overview]
Message-ID: <d824111e-3214-d7bb-9b28-abed32440df0@intel.com> (raw)
In-Reply-To: <F33A83B5-7AF0-4D44-AC92-BFFD1593EB3D@mellanox.com>
On 3/7/2018 9:36 PM, Yongseok Koh wrote:
>
>> On Mar 6, 2018, at 8:28 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> It is not clear which per port offloads are enabled. Printing offloads
>> values at forwarding start.
>>
>> CRC strip offload value was printed in more verbose manner, it is
>> removed since Rx/Tx offload values covers it and printing only CRC one
>> can cause confusion.
>>
>> Hexadecimal offloads values are not very user friendly but preferred to
>> not create to much noise during forwarding start.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Shahaf Shuler <shahafs@mellanox.com>
>> ---
>> app/test-pmd/config.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>> index 4bb255c62..47845d0cb 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -1682,10 +1682,9 @@ rxtx_config_display(void)
>> struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf;
>>
>> printf(" port %d:\n", (unsigned int)pid);
>> - printf(" CRC stripping %s\n",
>> - (ports[pid].dev_conf.rxmode.offloads &
>> - DEV_RX_OFFLOAD_CRC_STRIP) ?
>> - "enabled" : "disabled");
>> + printf(" Rx offloads=0x%"PRIx64" Tx Offloads=0x%"PRIx64"\n",
>> + ports[pid].dev_conf.rxmode.offloads,
>> + ports[pid].dev_conf.txmode.offloads);
>
> So, if someone wants to know what these values mean, they should type
> 'show port cap all'.
Indeed I forget about 'show port cap all', it is better way to display offloads,
still I believe it is good a have a brief info in the start, especially it
already has "tx_conf->offloads"
btw, 'show port cap all' is missing some offload values, it needs to be updated.
>
> BTW, tx_conf->offloads is printed a few lines later, then isn't it necessary to
> print rx_conf->offloads as well? Or, is it supposed to be identical to
> dev_conf.rxmode.offloads?
They may be different, good idea to add rx_conf->offloads as well. I will add it
in v2.
Thanks,
ferruh
>
> Thanks,
> Yongseok
>
next prev parent reply other threads:[~2018-03-09 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 16:28 Ferruh Yigit
2018-03-07 21:36 ` Yongseok Koh
2018-03-09 18:27 ` Ferruh Yigit [this message]
2018-03-12 14:59 ` Ferruh Yigit
2018-03-12 15:05 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-03-12 17:26 ` Yongseok Koh
2018-03-12 17:46 ` Ferruh Yigit
2018-03-12 17:53 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2018-03-13 9:24 ` Van Haaren, Harry
2018-03-13 10:21 ` Ferruh Yigit
2018-03-13 11:06 ` Van Haaren, Harry
2018-04-22 23:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d824111e-3214-d7bb-9b28-abed32440df0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=shahafs@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).