From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>,
thomas@monjalon.net, dev@dpdk.org
Cc: jananeex.m.parthasarathy@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v4 9/9] mk: update make targets for classified testcases
Date: Tue, 17 Jul 2018 15:33:48 +0100 [thread overview]
Message-ID: <d89fa912-c8a1-8e63-2e27-807b7462903e@intel.com> (raw)
In-Reply-To: <1531833331-18148-10-git-send-email-reshma.pattan@intel.com>
On 17-Jul-18 2:15 PM, Reshma Pattan wrote:
> Makefiles are updated with new test case lists.
> Test cases are classified as -
> P1 - Main test cases,
> P2 - Cryptodev/driver test cases,
> P3 - Perf test cases which takes longer than 10s,
> P4 - Logging/Dump test cases.
>
> Makefile is updated with different targets
> for the above classified groups.
> Test cases for different targets are listed accordingly.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> mk/rte.sdkroot.mk | 4 ++--
> mk/rte.sdktest.mk | 33 +++++++++++++++++++++++++++------
> 2 files changed, 29 insertions(+), 8 deletions(-)
>
> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
> index f43cc7829..ea3473ebf 100644
> --- a/mk/rte.sdkroot.mk
> +++ b/mk/rte.sdkroot.mk
> @@ -68,8 +68,8 @@ config defconfig showconfigs showversion showversionum:
> cscope gtags tags etags:
> $(Q)$(RTE_SDK)/devtools/build-tags.sh $@ $T
>
> -.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage
> -test test-basic test-fast test-ring test-mempool test-perf coverage:
> +.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage test-drivers test-dump
> +test test-basic test-fast test-ring test-mempool test-perf coverage test-drivers test-dump:
I'm probably missing something, but i can only see definitions for
coverage, test-fast, test-perf, test-drivers and test-dump.
What is the difference between test and test-basic, and what is
test-mempool? If they are unused, they should be removed.
> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@
>
> test: test-build
> diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk
> index ee1fe0c7e..13d1efb6a 100644
> --- a/mk/rte.sdktest.mk
> +++ b/mk/rte.sdktest.mk
> @@ -18,14 +18,35 @@ DIR := $(shell basename $(RTE_OUTPUT))
> #
> # test: launch auto-tests, very simple for now.
> #
> -.PHONY: test test-basic test-fast test-perf coverage
> +.PHONY: test test-basic test-fast test-perf test-drivers test-dump coverage
>
> -PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf
> -coverage: BLACKLIST=-$(PERFLIST)
> -test-fast: BLACKLIST=-$(PERFLIST)
> -test-perf: WHITELIST=$(PERFLIST)
> +PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf,\
> + reciprocal_division,reciprocal_division_perf,lpm_perf,red_all,\
> + barrier,hash_multiwriter,timer_racecond,efd,hash_functions,\
> + eventdev_selftest_sw,member_perf,efd_perf,lpm6_perf,red_perf,\
> + distributor_perf,ring_pmd_perf,pmd_perf,ring_perf
> +DRIVERSLIST=link_bonding,link_bonding_mode4,link_bonding_rssconf,\
> + cryptodev_sw_mrvl,cryptodev_dpaa2_sec,cryptodev_dpaa_sec,\
> + cryptodev_qat,cryptodev_aesni_mb,cryptodev_openssl,\
> + cryptodev_scheduler,cryptodev_aesni_gcm,cryptodev_null,\
> + cryptodev_sw_snow3g,cryptodev_sw_kasumi,cryptodev_sw_zuc
> +DUMPLIST=dump_struct_sizes,dump_mempool,dump_malloc_stats,dump_devargs,\
> + dump_log_types,dump_ring,quit,dump_physmem,dump_memzone,\
> + devargs_autotest
>
> -test test-basic test-fast test-perf:
> +SPACESTR:=
> +SPACESTR+=
> +STRIPPED_PERFLIST=$(subst $(SPACESTR),,$(PERFLIST))
> +STRIPPED_DRIVERSLIST=$(subst $(SPACESTR),,$(DRIVERSLIST))
> +STRIPPED_DUMPLIST=$(subst $(SPACESTR),,$(DUMPLIST))
> +
> +coverage: BLACKLIST=-$(STRIPPED_PERFLIST)
> +test-fast: BLACKLIST=-$(STRIPPED_PERFLIST),$(STRIPPED_DRIVERSLIST),$(STRIPPED_DUMPLIST)
> +test-perf: WHITELIST=$(STRIPPED_PERFLIST)
> +test-drivers: WHITELIST=$(STRIPPED_DRIVERSLIST)
> +test-dump: WHITELIST=$(STRIPPED_DUMPLIST)
> +
> +test test-basic test-fast test-perf test-drivers test-dump:
> @mkdir -p $(AUTOTEST_DIR) ; \
> cd $(AUTOTEST_DIR) ; \
> if [ -f $(RTE_OUTPUT)/app/test ]; then \
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-07-17 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1531833331-18148-1-git-send-email-reshma.pattan@intel.com>
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 1/9] autotest: fix printing Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 2/9] autotest: fix invalid code on reports Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 3/9] autotest: make autotest runner python 2/3 compliant Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 4/9] autotest: visually separate different test categories Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 5/9] autotest: improve filtering Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 7/9] autotest: properly parallelize unit tests Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 8/9] autotest: update autotest test case list Reshma Pattan
2018-07-17 13:15 ` [dpdk-stable] [PATCH v4 9/9] mk: update make targets for classified testcases Reshma Pattan
2018-07-17 14:33 ` Burakov, Anatoly [this message]
2018-07-17 15:23 ` Pattan, Reshma
2018-07-17 14:40 ` Burakov, Anatoly
2018-07-17 15:18 ` Pattan, Reshma
[not found] <cover.1528404133.git.anatoly.burakov@intel.com>
2018-07-17 10:39 ` Reshma Pattan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d89fa912-c8a1-8e63-2e27-807b7462903e@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).