From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] ring: build with global includes
Date: Mon, 21 Nov 2022 21:27:14 +0000 [thread overview]
Message-ID: <d8b89ca6dee54e508cc8d3addd022d81@huawei.com> (raw)
In-Reply-To: <20221121195327.GA24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
> -----Original Message-----
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Sent: Monday, November 21, 2022 7:53 PM
> To: Bruce Richardson <bruce.richardson@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] ring: build with global includes
>
> On Mon, Nov 21, 2022 at 10:31:29AM +0000, Bruce Richardson wrote:
> > On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote:
> > > ring has no dependencies and should be able to be built standalone but
> > > cannot be since it cannot find rte_config.h. this change directs meson
> > > to include global_inc paths just like is done with other libraries
> > > e.g. telemetry.
> > >
> > > Tyler Retzlaff (1):
> > > ring: build with global includes
> > >
> > > lib/ring/meson.build | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> >
> > I am a little confused by this change - how do you mean built-standalone?
> > The ring library depends upon EAL for memory management, does it not? Also,
> > no DPDK library can be built on its own without the rest of the top-level
> > build infrastructure, which will ensure that the global-include folders are
> > on the include path?
> >
> > In terms of other libs, e.g. telemetry, the only reason those need the
> > global includes added to their include path explicitly is because those are
> > built ahead of EAL. Anything that depends on EAL - including ring - will
> > have the global includes available.
>
> i'm having trouble seeing where in the meson.build that ring depends on
> eal can you point me to where it is?
>
> >
> > Can you explain a little more about the use-case you are looking at here,
> > and how you are attempting to build ring?
>
> so i found this by trying to understand other libraries dependencies
> through a process of disabling the build of various subsets.
>
> it's possible i didn't look deeply enough but i didn't see an explicit
> dependency on eal (in the meson.build files). maybe you can point out
> where it is because by just having rte_config.h available it compiles
> and links.
>
> e.g. i don't see.
>
> deps += ['eal']
>
> is the dependency on eal the library or just eal headers? because if it
> is header only it is equivalent to telemetry i think?
rte_ring.c uses bunch of EAL functions:
rte_zmalloc, rte_memzone_*, rte_log*, rte_mcfg*, etc.
> thanks!
>
> ty
>
> >
> > /Bruce
next prev parent reply other threads:[~2022-11-21 21:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 23:22 Tyler Retzlaff
2022-11-18 23:22 ` Tyler Retzlaff
2022-11-21 10:31 ` Bruce Richardson
2022-11-21 19:53 ` Tyler Retzlaff
2022-11-21 21:27 ` Konstantin Ananyev [this message]
2022-11-21 21:36 ` Thomas Monjalon
2022-11-21 22:48 ` Tyler Retzlaff
2022-11-22 8:51 ` David Marchand
2022-11-22 9:17 ` Bruce Richardson
2022-11-22 16:22 ` Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b89ca6dee54e508cc8d3addd022d81@huawei.com \
--to=konstantin.ananyev@huawei.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).