DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Dong Zhou <dongzhou@nvidia.com>,
	orika@nvidia.com, thomas@monjalon.net,
	Aman Singh <aman.deep.singh@intel.com>,
	Yuying Zhang <yuying.zhang@intel.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4] ethdev: add flow item for RoCE infiniband BTH
Date: Tue, 30 May 2023 18:46:20 +0100	[thread overview]
Message-ID: <d8ce203e-53c0-9bca-5bfc-5b85596ffc1d@amd.com> (raw)
In-Reply-To: <20230530030620.2935042-1-dongzhou@nvidia.com>

On 5/30/2023 4:06 AM, Dong Zhou wrote:
> IB(InfiniBand) is one type of networking used in high-performance
> computing with high throughput and low latency. Like Ethernet,
> IB defines a layered protocol (Physical, Link, Network, Transport
> Layers). IB provides native support for RDMA(Remote DMA), an
> extension of the DMA that allows direct access to remote host
> memory without CPU intervention. IB network requires NICs and
> switches to support the IB protocol.
> 
> RoCE(RDMA over Converged Ethernet) is a network protocol that
> allows RDMA to run on Ethernet. RoCE encapsulates IB packets on
> Ethernet and has two versions, RoCEv1 and RoCEv2. RoCEv1 is an
> Ethernet link layer protocol, IB packets are encapsulated in the
> Ethernet layer and use Ethernet type 0x8915. RoCEv2 is an internet
> layer protocol, IB packets are encapsulated in UDP payload and
> use a destination port 4791, The format of the RoCEv2 packet is
> as follows:
>   ETH + IP + UDP(dport 4791) + IB(BTH + ExtHDR + PAYLOAD + CRC)
> 
> BTH(Base Transport Header) is the IB transport layer header, RoCEv1
> and RoCEv2 both contain this header. This patch introduces a new
> RTE item to match the IB BTH in RoCE packets. One use of this match
> is that the user can monitor RoCEv2's CNP(Congestion Notification
> Packet) by matching BTH opcode 0x81.
> 
> This patch also adds the testpmd command line to match the RoCEv2
> BTH. Usage example:
> 
>   testpmd> flow create 0 group 1 ingress pattern
>            eth / ipv4 / udp dst is 4791 / ib_bth opcode is 0x81
>            dst_qp is 0xd3 / end actions queue index 0 / end
> 
> Signed-off-by: Dong Zhou <dongzhou@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> v2:
>  - Change "ethernet" name to "Ethernet" in the commit log.
>  - Add "RoCE" and "IB" 2 words to words-case.txt.
>  - Add "rte_byteorder.h" header file in "rte_ib.h" to fix compile errors.
>  - Add "Acked-by" labels in the first ethdev patch.
> 
> v3:
>  - Do rebase to fix the patch apply failure.
>  - Add "Acked-by" label in the second net/mlx5 patch.
> 
> v4:
>  - Split this series of patches, only keep the first ethdev patch.
>

Patch looks good, can you please add a release notes update too?

  reply	other threads:[~2023-05-30 17:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11  7:55 [PATCH v1 0/3] add support for infiniband BTH match Dong Zhou
2023-05-11  7:55 ` [PATCH v1 1/3] ethdev: add flow item for RoCE infiniband BTH Dong Zhou
2023-05-17 17:06   ` Ori Kam
2023-05-22  7:01     ` Andrew Rybchenko
2023-05-24  6:58       ` Bill Zhou
2023-05-11  7:55 ` [PATCH v1 2/3] net/mlx5: add support for infiniband BTH match Dong Zhou
2023-05-11  7:55 ` [PATCH v1 3/3] net/mlx5/hws: " Dong Zhou
2023-05-24 10:08 ` [PATCH v2 0/3] " Dong Zhou
2023-05-24 10:08   ` [PATCH v2 1/3] ethdev: add flow item for RoCE infiniband BTH Dong Zhou
2023-05-24 10:08   ` [PATCH v2 2/3] net/mlx5: add support for infiniband BTH match Dong Zhou
2023-05-24 12:54     ` Ori Kam
2023-05-24 10:08   ` [PATCH v2 3/3] net/mlx5/hws: " Dong Zhou
2023-05-25  7:40   ` [PATCH v3 0/3] " Dong Zhou
2023-05-25  7:40     ` [PATCH v3 1/3] ethdev: add flow item for RoCE infiniband BTH Dong Zhou
2023-05-25  7:40     ` [PATCH v3 2/3] net/mlx5: add support for infiniband BTH match Dong Zhou
2023-05-25  7:40     ` [PATCH v3 3/3] net/mlx5/hws: " Dong Zhou
2023-05-29 13:36       ` Alex Vesker
2023-05-30  3:06     ` [PATCH v4] ethdev: add flow item for RoCE infiniband BTH Dong Zhou
2023-05-30 17:46       ` Ferruh Yigit [this message]
2023-05-31  3:22         ` Dong Zhou
2023-05-31  3:26     ` [PATCH v5] " Dong Zhou
2023-05-31  8:01       ` [PATCH v6] " Dong Zhou
2023-05-31  8:47       ` [PATCH v5] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8ce203e-53c0-9bca-5bfc-5b85596ffc1d@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=dongzhou@nvidia.com \
    --cc=olivier.matz@6wind.com \
    --cc=orika@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).