From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Patrick Robb <probb@iol.unh.edu>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org, dpdklab <dpdklab@iol.unh.edu>,
Aaron Conole <aconole@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
"ci@dpdk.org" <ci@dpdk.org>
Subject: Re: [PATCH v13 00/11] net/tap: make RSS work again
Date: Tue, 21 May 2024 15:38:46 +0100 [thread overview]
Message-ID: <d9818604-e4be-4ce3-9f59-b98cc30738cc@amd.com> (raw)
In-Reply-To: <971f80f9-53fc-439a-9302-dcb908085ffa@amd.com>
On 5/21/2024 3:35 PM, Ferruh Yigit wrote:
> On 5/21/2024 3:19 PM, Ferruh Yigit wrote:
>> On 5/21/2024 3:47 AM, Stephen Hemminger wrote:
>>> The support of doing RSS for rte_flow_action was a cool idea
>>> but it has been broken for several releases of DPDK as the
>>> underlying kernel and BPF infrastructure changed.
>>>
>>> This series cleans up the BPF program, implements several
>>> features that were never completed in the original code
>>> and changes to use the current BPF tool chain.
>>>
>>> The result should be easier to read and maintain. I do not
>>> intend to support backporting this to stable releases due
>>> to lack of demand and dealing with older distros.
>>>
>>> v13 - Incorporate review feedback.
>>> Drop change to statistics and queue full handling;
>>> these will get fixed in another series.
>>>
>>> Stephen Hemminger (11):
>>> net/tap: fix fd check in flow_isolate
>>> net/tap: do not duplicate fd's
>>> net/tap: remove unused fields
>>> net/tap: validate and setup parameters for BPF RSS
>>> net/tap: do not build flow support if header is out of date
>>> net/tap: rewrite the RSS BPF program
>>> net/tap: use libbpf to load new BPF program
>>> net/tap: remove no longer used files
>>> net/tap: simplify internals
>>> net/tap: remove extraneous newlines
>>> net/tap: update documentation
>>>
>>
>> Thanks Stephen for the update, I don't have any new comment, but there
>> are some outstanding questions on v12 9/12, can you please check them?
>>
>
> Ah, I forgot that './devtools/check-meson.py' tool is complaining about
> some meson code.
>
Hi Patric,
I guess './devtools/check-meson.py' checks are missing in the CI, I
don't remember seeing any complain about it in the CI.
Is it possible to add this task to the CI task-list backlog?
next parent reply other threads:[~2024-05-21 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240130034925.44869-1-stephen@networkplumber.org>
[not found] ` <20240521024923.150983-1-stephen@networkplumber.org>
[not found] ` <2f66a687-ebf1-4471-a528-4119333d5e61@amd.com>
[not found] ` <971f80f9-53fc-439a-9302-dcb908085ffa@amd.com>
2024-05-21 14:38 ` Ferruh Yigit [this message]
2024-05-21 21:23 ` Patrick Robb
2024-05-21 21:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9818604-e4be-4ce3-9f59-b98cc30738cc@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aconole@redhat.com \
--cc=ci@dpdk.org \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=probb@iol.unh.edu \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).