From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "John Daley (johndale)" <johndale@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/enic: fix hardcoding of some flow director masks
Date: Thu, 9 Feb 2017 17:58:05 +0000 [thread overview]
Message-ID: <da7fdce9-53d7-30d2-9bb1-5a09af748aad@intel.com> (raw)
In-Reply-To: <ac7f8bfb38b54196ba136902b16d22a4@XCH-RCD-007.cisco.com>
On 2/9/2017 5:43 PM, John Daley (johndale) wrote:
>
>
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Thursday, February 09, 2017 2:16 AM
>> To: John Daley (johndale) <johndale@cisco.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [PATCH v2] net/enic: fix hardcoding of some flow director masks
>>
>> On 2/9/2017 12:40 AM, John Daley wrote:
>>> Hard coded mask values were being used for several of the IPv4 and
>>> IPv6 fields. Use the values in the rte_eth_fdir_masks structure
>>> provided by the caller.
>>>
>>> Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300
>>> series")
>>>
>>> Cc: stable@dpdk.org
>>> Signed-off-by: John Daley <johndale@cisco.com>
>>> ---
>>>
>>> v2: fix compile error
>>
>> I wasn't getting an error for this.
>>
>> V2 adds:
>>
>> - ipv6_val.vtc_flow = input->flow.ipv6_flow.tc << 16;
>> + ipv6_val.vtc_flow = input->flow.ipv6_flow.tc << 12;
>>
>> What is the compile error this fixes?
>
> This patch had the compile error:
> http://www.dpdk.org/dev/patchwork/patch/20147/
> + ipv6_mask.vtc_flow = masks->ipv6_mask.tc << 16);
I see, perhaps (don't remember) I fixed this while applying, because
next-net was compiling fine.
next prev parent reply other threads:[~2017-02-09 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:54 [dpdk-stable] [PATCH 1/2] " John Daley
2017-02-03 9:54 ` [dpdk-stable] [PATCH 2/2] net/enic: fix flow director IPv6 traffic class specification John Daley
2017-02-03 22:54 ` [dpdk-stable] [PATCH 1/2] net/enic: fix hardcoding of some flow director masks Ferruh Yigit
[not found] ` <20170209003130.17245-1-johndale@cisco.com>
2017-02-09 0:31 ` [dpdk-stable] [PATCH v2] " John Daley
[not found] ` <20170209004009.26242-1-johndale@cisco.com>
2017-02-09 0:40 ` John Daley
2017-02-09 10:16 ` Ferruh Yigit
2017-02-09 17:43 ` John Daley (johndale)
2017-02-09 17:58 ` Ferruh Yigit [this message]
2017-02-09 12:21 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da7fdce9-53d7-30d2-9bb1-5a09af748aad@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).