From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Igor Russkikh <irusskikh@marvell.com>, dev@dpdk.org
Cc: Rasesh Mody <rmody@marvell.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [RFC PATCH v2] app/testpmd: tx pkt clones parameter in flowgen
Date: Mon, 12 Oct 2020 19:13:27 +0100 [thread overview]
Message-ID: <dbfd19fc-da00-f337-96c4-ba2cbbf81749@intel.com> (raw)
In-Reply-To: <20200925090757.1338-1-irusskikh@marvell.com>
On 9/25/2020 10:07 AM, Igor Russkikh wrote:
> When testing high performance numbers, it is often that CPU performance
> limits the max values device can reach (both in pps and in gbps)
>
> Here instead of recreating each packet separately, we use clones counter
> to resend the same mbuf to the line multiple times.
>
Do you have any numbers on how much performance improvement gained?
> PMDs handle that transparently due to reference counting inside of mbuf.
>
> Verified on Marvell qede and atlantic PMDs.
>
> v2: increment ref counter for each mbuf pointer copy
>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
<...>
> @@ -1151,6 +1153,16 @@ launch_args_parse(int argc, char** argv)
> else
> nb_pkt_per_burst = (uint16_t) n;
> }
> + if (!strcmp(lgopts[opt_idx].name, "clones")) {
> + n = atoi(optarg);
> + if ((n >= 0) &&
> + (n <= nb_pkt_per_burst))
> + nb_pkt_clones = (uint16_t) n;
> + else
> + rte_exit(EXIT_FAILURE,
> + "clones must be >= 0 and <= %d (burst)\n",
> + nb_pkt_per_burst);
Do you need to enforce the "n <= nb_pkt_per_burst", burst value can be changed
later and trying to keep 'clones' values in sync with it is additional work.
In the flowgen logic, with each burst a new packet is created anyway. So instead
of enforcing the 'clones' number range, in documentation you can say the clone
number can't exceed the burst number whatever it is set.
> + }
> if (!strcmp(lgopts[opt_idx].name, "mbcache")) {
> n = atoi(optarg);
> if ((n >= 0) &&
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index fe6450cc0..18b4b63d1 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -228,6 +228,7 @@ uint32_t tx_pkt_times_intra;
> /**< Timings for send scheduling in TXONLY mode, time between packets. */
>
> uint16_t nb_pkt_per_burst = DEF_PKT_BURST; /**< Number of packets per burst. */
> +uint16_t nb_pkt_clones; /**< Number of tx packet clones to send. */
> uint16_t mb_mempool_cache = DEF_MBUF_CACHE; /**< Size of mbuf mempool cache. */
>
Both the parameter name, 'clones', and the variable name 'nb_pkt_clones' are too
generic, and may mislead users. Please remember that testpms usage is very wide.
You are updating very specifically the flowgen forwarding engine, can you please
prefix the 'flowgen', like:
'flowgen-clones' & 'nb_pkt_flowgen_clones'.
Also explicitly mention in the description that this is for flowgen clones.
<...>
next prev parent reply other threads:[~2020-10-12 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 9:07 Igor Russkikh
2020-10-12 18:13 ` Ferruh Yigit [this message]
2020-10-12 19:37 ` [dpdk-dev] [EXT] " Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbfd19fc-da00-f337-96c4-ba2cbbf81749@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=irusskikh@marvell.com \
--cc=rmody@marvell.com \
--cc=stephen@networkplumber.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).