From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jesna K E <jesna.k.e@amd.com>, dev@dpdk.org
Cc: Selwin.Sebastian@amd.com
Subject: Re: [PATCH v1 2/3] net/axgbe: correct API call when offload enabled
Date: Mon, 13 Nov 2023 16:55:30 +0000 [thread overview]
Message-ID: <dc2ebfc5-880c-4cc8-b24c-ac6de49bc0ee@amd.com> (raw)
In-Reply-To: <abad076a-ee49-4e39-a858-32b0a5826036@amd.com>
On 11/13/2023 3:23 PM, Ferruh Yigit wrote:
> On 11/11/2023 4:00 PM, Jesna K E wrote:
>> Fixes: 9963b5131af8 ("net/axgbe: support multi-process")
>>
>
> Can you please add more description?
>
>
>> Signed-off-by: Jesna K E <jesna.k.e@amd.com>
>> ---
>> drivers/net/axgbe/axgbe_ethdev.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c
>> index e12ee3e17a..e1cb60c1c3 100644
>> --- a/drivers/net/axgbe/axgbe_ethdev.c
>> +++ b/drivers/net/axgbe/axgbe_ethdev.c
>> @@ -2130,16 +2130,18 @@ void
>> axgbe_set_tx_function(struct rte_eth_dev *dev)
>> {
>> struct axgbe_port *pdata = dev->data->dev_private;
>> + struct axgbe_tx_queue *txq = dev->data->tx_queues[0];
>>
>> if (pdata->multi_segs_tx)
>> dev->tx_pkt_burst = &axgbe_xmit_pkts_seg;
>> + else if (txq->vector_disable ||
>> + rte_vect_get_max_simd_bitwidth() < RTE_VECT_SIMD_128)
>> + dev->tx_pkt_burst = &axgbe_xmit_pkts;
>> + else
>> #ifdef RTE_ARCH_X86
>> - struct axgbe_tx_queue *txq = dev->data->tx_queues[0];
>> - if (!txq->vector_disable &&
>> - rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
>> dev->tx_pkt_burst = &axgbe_xmit_pkts_vec;
>> #else
>> - dev->tx_pkt_burst = &axgbe_xmit_pkts;
>> + dev->tx_pkt_burst = &axgbe_xmit_pkts;
>> #endif
>> }
>>
>
> What about following for simplification:
>
> {
> tx_pkt_burst = &axgbe_xmit_pkts;
>
> if (pdata->multi_segs_tx)
> tx_pkt_burst = &axgbe_xmit_pkts_seg;
> else if (!vector_disable &&
> rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
> tx_pkt_burst = &axgbe_xmit_pkts_vec;
> }
btw, there is a build error [1], about implicit declaration of function
and enum, which can be fixed by included relevant header [2].
[1]
https://mails.dpdk.org/archives/test-report/2023-November/508556.html
[2]
+ #include <rte_vect.h>
next prev parent reply other threads:[~2023-11-13 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 16:00 [PATCH v1 1/3] net/axgbe: packet size doesn't exceed the configured MTU Jesna K E
2023-11-11 16:00 ` [PATCH v1 2/3] net/axgbe: correct API call when offload enabled Jesna K E
2023-11-13 15:23 ` Ferruh Yigit
2023-11-13 16:55 ` Ferruh Yigit [this message]
2023-11-14 6:07 ` [PATCH v2] net/axgbe: invoke correct API when offloads enabled Jesna K E
2023-11-14 7:15 ` Jesna K E
2023-11-15 5:56 ` [PATCH v3] " Jesna K E
2023-11-15 11:57 ` Ferruh Yigit
2023-11-15 12:54 ` Sebastian, Selwin
2023-11-15 12:59 ` Ferruh Yigit
2023-11-11 16:00 ` [PATCH v1 3/3] net/axgbe: support TSO Implementation Jesna K E
2023-11-15 19:33 ` Ferruh Yigit
2023-11-16 9:44 ` [PATCH v2] net/axgbe: support TSO Jesna K E
2023-11-16 16:03 ` [PATCH v3] " Jesna K E
2023-11-17 18:34 ` Ferruh Yigit
2023-11-13 15:07 ` [PATCH v1 1/3] net/axgbe: packet size doesn't exceed the configured MTU Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc2ebfc5-880c-4cc8-b24c-ac6de49bc0ee@amd.com \
--to=ferruh.yigit@amd.com \
--cc=Selwin.Sebastian@amd.com \
--cc=dev@dpdk.org \
--cc=jesna.k.e@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).