From: Olivier Matz <olivier.matz@6wind.com>
To: Zoltan Kiss <zoltan.kiss@schaman.hu>, dev@dpdk.org
Cc: David Hunt <david.hunt@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] mempool: fix lack of free() registration
Date: Tue, 19 Jul 2016 17:26:53 +0200 [thread overview]
Message-ID: <dc3659b1-2c41-9824-71df-5b856e653f14@6wind.com> (raw)
In-Reply-To: <1468939061-19734-1-git-send-email-zoltan.kiss@schaman.hu>
Hi Zoltan,
I ran ./scripts/check-git-log.sh on your patch, showing some minor
styling issues:
On 07/19/2016 04:37 PM, Zoltan Kiss wrote:
> [PATCH] mempool: fix lack of free() registration
"()" should be removed
> The new mempool handler interface forgets to register the free() function
> of the ops. Introduced in this patch:
>
> 449c49b9 mempool: support handler operations
The format should be:
Fixes: 449c49b93a6b ("mempool: support handler operations")
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@schaman.hu>
> ---
> lib/librte_mempool/rte_mempool_ops.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c
> index fd0b64c..5f24de2 100644
> --- a/lib/librte_mempool/rte_mempool_ops.c
> +++ b/lib/librte_mempool/rte_mempool_ops.c
> @@ -81,6 +81,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h)
> ops = &rte_mempool_ops_table.ops[ops_index];
> snprintf(ops->name, sizeof(ops->name), "%s", h->name);
> ops->alloc = h->alloc;
> + ops->free = h->free;
> ops->enqueue = h->enqueue;
> ops->dequeue = h->dequeue;
> ops->get_count = h->get_count;
>
Apart from that:
Acked-by: Olivier Matz <olivier.matz@6wind.com>
+CC Thomas, I think it should be included in 16.07.
Thanks!
next prev parent reply other threads:[~2016-07-19 15:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 14:37 Zoltan Kiss
2016-07-19 14:37 ` [dpdk-dev] [PATCH] mempool: adjust name string size in related data types Zoltan Kiss
2016-07-19 15:37 ` Olivier Matz
2016-07-19 15:59 ` Zoltan Kiss
2016-07-19 16:17 ` Olivier Matz
2016-07-20 12:41 ` Zoltan Kiss
2016-07-20 13:37 ` Olivier Matz
2016-07-20 14:01 ` Richardson, Bruce
2016-07-20 17:20 ` Zoltan Kiss
2016-07-20 17:16 ` [dpdk-dev] [PATCH v2] " Zoltan Kiss
2016-07-21 13:40 ` Olivier Matz
2016-07-21 13:47 ` Zoltan Kiss
2016-07-21 14:25 ` Olivier Matz
2016-07-21 21:16 ` Thomas Monjalon
2016-07-19 15:26 ` Olivier Matz [this message]
2016-07-19 16:17 ` [dpdk-dev] [PATCH] mempool: fix lack of free() registration Zoltan Kiss
2016-07-20 17:14 ` [dpdk-dev] [PATCH v2] mempool: fix lack of free registration Zoltan Kiss
2016-07-21 21:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc3659b1-2c41-9824-71df-5b856e653f14@6wind.com \
--to=olivier.matz@6wind.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=zoltan.kiss@schaman.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).