From: David Hunt <david.hunt@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>,
dev@dpdk.org, Jeff Guo <jia.guo@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Liang Ma <liang.j.ma@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver
Date: Mon, 26 Apr 2021 15:20:05 +0100 [thread overview]
Message-ID: <dc78d217-bdec-0080-f78b-6b4ac28ef5f7@intel.com> (raw)
In-Reply-To: <bec636928d88d4dbad69a75b0abf18690ffae5ad.1619444945.git.anatoly.burakov@intel.com>
Hi Anatoly,
On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> When .get_monitor_addr API was introduced, it was implemented in the
> ixgbe driver, but only for the physical function; the virtual function
> portion of the driver does not support that API.
>
> Add the missing function pointer to VF device structure.
>
> Fixes: 3982b7967bb7 ("net/ixgbe: implement power management API")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ff65145f55..6cca039a11 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -605,6 +605,7 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
> .rss_hash_update = ixgbe_dev_rss_hash_update,
> .rss_hash_conf_get = ixgbe_dev_rss_hash_conf_get,
> .tx_done_cleanup = ixgbe_dev_tx_done_cleanup,
> + .get_monitor_addr = ixgbe_get_monitor_addr,
> };
>
> /* store statistics names and its offset in stats structure */
Thanks for the fix. I ran get_monitor_address() on some ixgbe virtual
functions here, and can confirm that this patch resolves the issue.
Reviewed-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2021-04-26 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 13:49 Anatoly Burakov
2021-04-26 13:49 ` [dpdk-dev] [PATCH v1 2/2] net/i40e: " Anatoly Burakov
2021-04-26 14:22 ` David Hunt
2021-04-28 1:22 ` Zhang, Qi Z
2021-04-26 14:20 ` David Hunt [this message]
2021-04-27 1:42 ` [dpdk-dev] [PATCH v1 1/2] net/ixgbe: " Wang, Haiyue
2021-04-28 1:21 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc78d217-bdec-0080-f78b-6b4ac28ef5f7@intel.com \
--to=david.hunt@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=liang.j.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).