From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: Ashwin Sekhar T K <asekhar@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini
Date: Tue, 20 Jun 2023 11:29:52 +0200 [thread overview]
Message-ID: <dd063c4d-526c-753d-efe8-10bc8036ac9f@6wind.com> (raw)
In-Reply-To: <CO1PR18MB4540871A324342AB4024F290BF5CA@CO1PR18MB4540.namprd18.prod.outlook.com>
Hello Ashwin,
I will resend a patch with a fix also in npa_aura_pool_fini
Thierry
On 6/20/23 11:27, Ashwin Sekhar T K wrote:
> Hi Thierry,
>
> Could you please add the same fix in npa_aura_pool_fini() as well.
>
> Thanks
> Ashwin Sekhar T K
>
>> -----Original Message-----
>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>> Sent: Tuesday, June 20, 2023 2:22 PM
>> To: dev@dpdk.org
>> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
>> <thomas@monjalon.net>; Nithin Kumar Dabilpuram
>> <ndabilpuram@marvell.com>; Satha Koteswara Rao Kottidi
>> <skoteshwar@marvell.com>; Jerin Jacob Kollanukkaran
>> <jerinj@marvell.com>
>> Subject: [EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> Unlock mbox when an error is detected.
>>
>> Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC
>> APIs')
>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>> ---
>> drivers/common/cnxk/roc_npa.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/common/cnxk/roc_npa.c
>> b/drivers/common/cnxk/roc_npa.c index 377439c2baaf..38e149da82cc
>> 100644
>> --- a/drivers/common/cnxk/roc_npa.c
>> +++ b/drivers/common/cnxk/roc_npa.c
>> @@ -245,8 +245,10 @@ npa_aura_fini(struct mbox *m_box, uint32_t
>> aura_id)
>> if (rc < 0)
>> goto exit;
>>
>> - if (aura_rsp->hdr.rc != 0)
>> - return NPA_ERR_AURA_POOL_FINI;
>> + if (aura_rsp->hdr.rc != 0) {
>> + rc = NPA_ERR_AURA_POOL_FINI;
>> + goto exit;
>> + }
>>
>> /* Sync NDC-NPA for LF */
>> ndc_req = mbox_alloc_msg_ndc_sync_op(mbox);
>> --
>> 2.39.2
>
--
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/
Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware
next prev parent reply other threads:[~2023-06-20 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 8:51 Thierry Herbelot
2023-06-20 9:27 ` [EXT] " Ashwin Sekhar T K
2023-06-20 9:29 ` Thierry Herbelot [this message]
2023-06-20 9:32 ` David Marchand
2023-06-20 9:49 ` Thierry Herbelot
2023-06-20 9:39 ` [PATCH v2] common/cnxk/roc_npa: unlock mbox in error cases Thierry Herbelot
2023-06-20 9:43 ` [PATCH v3] " Thierry Herbelot
2023-06-21 4:46 ` [EXT] " Ashwin Sekhar T K
2023-06-21 5:00 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd063c4d-526c-753d-efe8-10bc8036ac9f@6wind.com \
--to=thierry.herbelot@6wind.com \
--cc=asekhar@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).