From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Michal Schmidt <mschmidt@redhat.com>, dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] net/iavf: fix mbuf VLAN offload flags in the L2TAG2 path with AVX2
Date: Tue, 13 Dec 2022 09:17:50 +0100 [thread overview]
Message-ID: <ddcf6b5a-fdd1-ef49-88c2-e560536aab38@redhat.com> (raw)
In-Reply-To: <20221208121916.155132-1-mschmidt@redhat.com>
Hi Michal,
On 12/8/22 13:19, Michal Schmidt wrote:
> It has been observed that mbufs of some received VLAN packets had the
> VLAN tag correctly set in vlan_tci, but ol_flags were missing the
> VLAN-indicating flags.
>
> _mm256_shuffle_epi8 operates as two independent 128-bit operations,
> not as a single 256-bit operation. To have the RTE_MBUF_F_RX_VLAN* flags
> reflected in the resulting vlan_flags for all 8 rx descriptors, the
> input l2tag2_flags_shuf must contain the required pattern in both
> 128-bit halves.
>
> Fixes: 3a1aca384d3a ("net/iavf: fix VLAN tag extraction handling")
Adding stable ML since bug was introduced in v21.05:
Cc: stable@dpdk.org
Maybe no need to resubmit and maintainer can add it when applying.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> ---
> drivers/net/iavf/iavf_rxtx_vec_avx2.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
> index 862f6eb0c0..b4ebac9d34 100644
> --- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c
> +++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
> @@ -1074,7 +1074,10 @@ _iavf_recv_raw_pkts_vec_avx2_flex_rxd(struct iavf_rx_queue *rxq,
> _mm256_set_epi8(0, 0, 0, 0,
> 0, 0, 0, 0,
> 0, 0, 0, 0,
> - 0, 0, 0, 0,
> + 0, 0,
> + RTE_MBUF_F_RX_VLAN |
> + RTE_MBUF_F_RX_VLAN_STRIPPED,
> + 0,
> /* end up 128-bits */
> 0, 0, 0, 0,
> 0, 0, 0, 0,
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
parent reply other threads:[~2022-12-13 8:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221208121916.155132-1-mschmidt@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddcf6b5a-fdd1-ef49-88c2-e560536aab38@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=mschmidt@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).