From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Suanming Mou <suanmingm@nvidia.com>, Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data structure
Date: Thu, 1 Feb 2024 11:20:33 +0000 [thread overview]
Message-ID: <de3a38fd-d955-43e8-bb95-ec64db6e6eed@amd.com> (raw)
In-Reply-To: <CO6PR12MB5396C4918317C92BB5929FCBC1432@CO6PR12MB5396.namprd12.prod.outlook.com>
On 2/1/2024 11:09 AM, Suanming Mou wrote:
>
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@amd.com>
>> Sent: Thursday, February 1, 2024 6:56 PM
>> To: Suanming Mou <suanmingm@nvidia.com>; Ori Kam <orika@nvidia.com>;
>> Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang
>> <yuying.zhang@intel.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava
>> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; NBU-
>> Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Andrew
>> Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Cc: dev@dpdk.org
>> Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data structure
>>
>> On 1/31/2024 2:57 AM, Suanming Mou wrote:
>>> Hi,
>>>
>>>> -----Original Message-----
>>>> From: Ferruh Yigit <ferruh.yigit@amd.com>
>>>> Sent: Wednesday, January 31, 2024 1:19 AM
>>>> To: Suanming Mou <suanmingm@nvidia.com>; Ori Kam <orika@nvidia.com>;
>>>> Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang
>>>> <yuying.zhang@intel.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>;
>>>> Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
>>>> <matan@nvidia.com>; NBU- Contact-Thomas Monjalon (EXTERNAL)
>>>> <thomas@monjalon.net>; Andrew Rybchenko
>>>> <andrew.rybchenko@oktetlabs.ru>
>>>> Cc: dev@dpdk.org
>>>> Subject: Re: [PATCH v3 1/3] ethdev: rename action modify field data
>>>> structure
>>>>
>>>> On 1/15/2024 9:13 AM, Suanming Mou wrote:
>>>>> Current rte_flow_action_modify_data struct describes the pkt field
>>>>> perfectly and is used only in action.
>>>>>
>>>>> It is planned to be used for item as well. This commit renames it to
>>>>> "rte_flow_field_data" making it compatible to be used by item.
>>>>>
>>>>
>>>> ack to rename struct to use in pattern.
>>>>
>>>>> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
>>>>> Acked-by: Ori Kam <orika@nvidia.com>
>>>>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>>>> ---
>>>>> app/test-pmd/cmdline_flow.c | 2 +-
>>>>> doc/guides/prog_guide/rte_flow.rst | 2 +-
>>>>> doc/guides/rel_notes/release_24_03.rst | 1 +
>>>>> drivers/net/mlx5/mlx5_flow.c | 4 ++--
>>>>> drivers/net/mlx5/mlx5_flow.h | 6 +++---
>>>>> drivers/net/mlx5/mlx5_flow_dv.c | 10 +++++-----
>>>>> lib/ethdev/rte_flow.h | 8 ++++----
>>>>> 7 files changed, 17 insertions(+), 16 deletions(-)
>>>>>
>>>>> diff --git a/app/test-pmd/cmdline_flow.c
>>>>> b/app/test-pmd/cmdline_flow.c index ce71818705..3725e955c7 100644
>>>>> --- a/app/test-pmd/cmdline_flow.c
>>>>> +++ b/app/test-pmd/cmdline_flow.c
>>>>> @@ -740,7 +740,7 @@ enum index {
>>>>> #define ITEM_RAW_SIZE \
>>>>> (sizeof(struct rte_flow_item_raw) + ITEM_RAW_PATTERN_SIZE)
>>>>>
>>>>> -/** Maximum size for external pattern in struct
>>>>> rte_flow_action_modify_data. */
>>>>> +/** Maximum size for external pattern in struct rte_flow_field_data.
>>>>> +*/
>>>>> #define ACTION_MODIFY_PATTERN_SIZE 32
>>>>>
>>>>
>>>> What do you think to update 'ACTION_MODIFY_PATTERN_SIZE' here too,
>>>> instead of next patch?
>>>
>>> Agree.
>>>
>>>>
>>>> <...>
>>>>
>>>>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index
>>>>> affdc8121b..40f6dcaacd 100644
>>>>> --- a/lib/ethdev/rte_flow.h
>>>>> +++ b/lib/ethdev/rte_flow.h
>>>>> @@ -3910,9 +3910,9 @@ enum rte_flow_field_id {
>>>>> * @warning
>>>>> * @b EXPERIMENTAL: this structure may change without prior notice
>>>>> *
>>>>> - * Field description for MODIFY_FIELD action.
>>>>> + * Field description for packet field.
>>>>>
>>>>
>>>> New note is not very helpful, how can we make it more useful?
>>>>
>>>> Does it make sense to keep 'MODIFY_FIELD' and add 'COMPARE ITEM' in
>>>> next patch, to clarify the intended usage for the struct, otherwise it is too
>> generic.
>>>
>>> OK, sorry, the purpose is to make it generic. So next time if other ITEM or
>> ACTION need that field, it can be used directly.
>>> Otherwise, it feels like it can only be used by 'MODIFY_FIELD' and
>> 'COMPARE_ITEM', what do you think?
>>>
>>
>> I don't have an intention to limit its usage, but to clarify usage for whoever checks
>> the document.
>>
>> "Field description for packet field." doesn't say what exactly it is and cause
>> confusion.
>>
>> Perhaps wording can be changed to say two possible usages are for
>> 'MODIFY_FIELD' and 'COMPARE_ITEM'?
>
> Sounds good, OK, I will update.
>
> BTW, I saw the patch apply failed, seems it is due to Raslan's branch has some extra features than your branch.
> So I just want to know is it OK? Or should I still base on your branch? When will the branches be synced.
>
Thanks.
Can you please rebase next version on next-net, this way we can benefit
from CI checks?
next prev parent reply other threads:[~2024-02-01 11:20 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 3:12 [PATCH 0/2] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2023-12-14 3:12 ` [PATCH 1/2] " Suanming Mou
2023-12-14 3:12 ` [PATCH 2/2] net/mlx5: add compare item support Suanming Mou
2023-12-19 1:33 ` [PATCH v2 0/3] [PATCH 0/2] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2023-12-19 1:33 ` [PATCH v2 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-01-09 14:07 ` Ori Kam
2024-01-12 8:03 ` Andrew Rybchenko
2023-12-19 1:33 ` [PATCH v2 2/3] ethdev: add compare item Suanming Mou
2024-01-09 14:26 ` Ori Kam
2024-01-12 8:11 ` Andrew Rybchenko
2024-01-15 8:14 ` Suanming Mou
2023-12-19 1:33 ` [PATCH v2 3/3] net/mlx5: add compare item support Suanming Mou
2024-01-09 14:28 ` Ori Kam
2024-01-15 9:13 ` [PATCH v3 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2024-01-15 9:13 ` [PATCH v3 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-01-30 17:19 ` Ferruh Yigit
2024-01-31 2:57 ` Suanming Mou
2024-02-01 10:56 ` Ferruh Yigit
2024-02-01 11:09 ` Suanming Mou
2024-02-01 11:20 ` Ferruh Yigit [this message]
2024-02-01 11:39 ` Suanming Mou
2024-01-15 9:13 ` [PATCH v3 2/3] ethdev: add compare item Suanming Mou
2024-01-30 17:33 ` Ferruh Yigit
2024-01-31 2:47 ` Suanming Mou
2024-01-31 15:56 ` Ori Kam
2024-01-31 16:46 ` Ferruh Yigit
2024-01-31 17:43 ` Ori Kam
2024-01-31 17:54 ` Ferruh Yigit
2024-02-01 6:51 ` Ori Kam
2024-02-01 0:31 ` Suanming Mou
2024-01-15 9:13 ` [PATCH v3 3/3] net/mlx5: add compare item support Suanming Mou
2024-02-01 2:30 ` [PATCH v4 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2024-02-01 2:30 ` [PATCH v4 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-02-01 2:30 ` [PATCH v4 2/3] ethdev: add compare item Suanming Mou
2024-02-01 2:30 ` [PATCH v4 3/3] net/mlx5: add compare item support Suanming Mou
2024-02-01 12:29 ` [PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2024-02-01 12:29 ` [PATCH v5 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-02-01 18:57 ` Ferruh Yigit
2024-02-01 12:29 ` [PATCH v5 2/3] ethdev: add compare item Suanming Mou
2024-02-01 18:57 ` Ferruh Yigit
2024-02-01 12:29 ` [PATCH v5 3/3] net/mlx5: add compare item support Suanming Mou
2024-02-01 18:57 ` Ferruh Yigit
2024-02-01 18:56 ` [PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Ferruh Yigit
2024-02-02 0:32 ` Suanming Mou
2024-02-02 0:42 ` [PATCH v6 " Suanming Mou
2024-02-02 0:42 ` [PATCH v6 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-02-05 11:23 ` Thomas Monjalon
2024-02-05 11:49 ` Suanming Mou
2024-02-05 12:39 ` Thomas Monjalon
2024-02-05 12:53 ` Suanming Mou
2024-02-02 0:42 ` [PATCH v6 2/3] ethdev: add compare item Suanming Mou
2024-02-05 13:00 ` Thomas Monjalon
2024-02-05 13:28 ` Suanming Mou
2024-02-05 14:09 ` Thomas Monjalon
2024-02-06 1:26 ` Suanming Mou
2024-02-02 0:42 ` [PATCH v6 3/3] net/mlx5: add compare item support Suanming Mou
2024-02-06 2:06 ` [PATCH v7 0/4] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2024-02-06 2:06 ` [PATCH v7 1/4] ethdev: rename action modify field data structure Suanming Mou
2024-02-06 21:23 ` Ferruh Yigit
2024-02-06 2:06 ` [PATCH v7 2/4] ethdev: move flow field data structures Suanming Mou
2024-02-06 21:23 ` Ferruh Yigit
2024-02-06 2:06 ` [PATCH v7 3/4] ethdev: add compare item Suanming Mou
2024-02-06 21:24 ` Ferruh Yigit
2024-02-06 2:06 ` [PATCH v7 4/4] net/mlx5: add compare item support Suanming Mou
2024-02-06 21:23 ` Ferruh Yigit
2024-02-06 21:24 ` [PATCH v7 0/4] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de3a38fd-d955-43e8-bb95-ec64db6e6eed@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).