From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Junxiao Shi <git@mail1.yoursunny.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] net/memif: change socket listener owner uid/gid
Date: Wed, 7 Dec 2022 16:56:24 +0000 [thread overview]
Message-ID: <deaa6be8-62e0-cbcb-a3f4-e676fc1cc35c@amd.com> (raw)
In-Reply-To: <7046cb75-75e7-8be6-9efc-f37b70a1f2df@amd.com>
On 12/7/2022 3:43 PM, Ferruh Yigit wrote:
> On 12/7/2022 2:41 PM, Junxiao Shi wrote:
>> This allows a DPDK application running with root privilege to create a
>> memif socket listener with non-root owner uid and gid, which can be
>> connected from client applications running without root privilege.
>>
>
> Do you have an easy way to test unprivileged memif client?
>
>> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
>
> <...>
>
>> @@ -1827,47 +1859,58 @@ rte_pmd_memif_probe(struct rte_vdev_device *vdev)
>> flags |= ETH_MEMIF_FLAG_SOCKET_ABSTRACT;
>>
>> kvlist = rte_kvargs_parse(rte_vdev_device_args(vdev), valid_arguments);
>> + if (kvlist == NULL) {
>> + MIF_LOG(ERR, "Invalid kvargs key");
>> + ret = -EINVAL;
>> + goto exit;
>> + }
>
> Thanks Junxiao for updating this, but since it is not really related to
> this patch, can you please separate it to another patch?
Also I am not sure what 'rte_kvargs_parse()' returns if there is no
argument provided (that may be the case if all default values are desired).
If API returns NULL for that case, above error log can be wrong, can you
please check.
next prev parent reply other threads:[~2022-12-07 16:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 20:44 [RFC PATCH] " Junxiao Shi
2022-11-15 23:53 ` Stephen Hemminger
2022-11-16 13:09 ` [RFC PATCH v2] " Junxiao Shi
2022-11-16 17:04 ` Stephen Hemminger
2022-11-16 17:14 ` [RFC PATCH v3] " Junxiao Shi
2022-11-16 17:14 ` [PATCH] " Junxiao Shi
2022-12-07 14:28 ` Ferruh Yigit
2022-12-07 14:41 ` [PATCH v2] " Junxiao Shi
2022-12-07 15:43 ` Ferruh Yigit
2022-12-07 16:56 ` Ferruh Yigit [this message]
2022-12-07 17:48 ` Junxiao Shi
2022-12-08 14:29 ` Ferruh Yigit
2022-12-07 15:53 ` [PATCH v3] " Junxiao Shi
2022-12-08 16:25 ` Ferruh Yigit
2022-12-08 16:25 ` Ferruh Yigit
2022-11-16 17:52 ` [RFC PATCH " Stephen Hemminger
2022-12-07 11:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deaa6be8-62e0-cbcb-a3f4-e676fc1cc35c@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=git@mail1.yoursunny.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).