From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xueming Li <xuemingl@mellanox.com>
Cc: dev@dpdk.org, Asaf@dpdk.org, "Penso <asafp"@mellanox.com
Subject: Re: [dpdk-dev] [v2] vdpa/mlx5: fix queue update synchronization
Date: Mon, 3 Aug 2020 17:56:23 +0200 [thread overview]
Message-ID: <deab9686-64ac-c631-4c91-c47a62f740ac@redhat.com> (raw)
In-Reply-To: <1596360111-5088-1-git-send-email-xuemingl@mellanox.com>
On 8/2/20 11:21 AM, Xueming Li wrote:
> The driver CQ event management is done by non vhost library thread,
> either the dpdk host thread or the internal vDPA driver thread.
>
> When a queue is updated the CQ may be destroyed and created by the vhost
> library thread via the queue state operation.
>
> When the queue update feature was added, it didn't synchronize the CQ
> management to the queue update what may cause invalid memory access.
>
> Add the aforementioned synchronization by a new per device configuration
> mutex.
>
> Fixes: c47d6e83334e ("vdpa/mlx5: support queue update")
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa.c | 8 +++++++-
> drivers/vdpa/mlx5/mlx5_vdpa.h | 1 +
> drivers/vdpa/mlx5/mlx5_vdpa_event.c | 8 ++++++++
> 3 files changed, 16 insertions(+), 1 deletion(-)
>
Applied to dpdk-next-virtio/master with suggested change.
Thanks,
Maxime
prev parent reply other threads:[~2020-08-03 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 8:14 [dpdk-dev] [PATCH] vdpa/mlx5: add device configuration lock Xueming Li
2020-08-02 9:21 ` [dpdk-dev] [v2] vdpa/mlx5: fix queue update synchronization Xueming Li
2020-08-03 9:50 ` Maxime Coquelin
2020-08-03 11:12 ` Xueming(Steven) Li
2020-08-03 14:34 ` Maxime Coquelin
2020-08-03 15:56 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deab9686-64ac-c631-4c91-c47a62f740ac@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc="Penso <asafp"@mellanox.com \
--cc=Asaf@dpdk.org \
--cc=dev@dpdk.org \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).