From: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
To: David Marchand <david.marchand@redhat.com>, <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] mem: allow using ASan in multi-process mode
Date: Mon, 9 Oct 2023 13:05:06 +0200 [thread overview]
Message-ID: <def0cf1a-a2b6-4af5-9126-e9596f64455a@intel.com> (raw)
In-Reply-To: <CAJFAV8wKp6=-WjmHVpqnE_MnukDCOvVoet90ZfS--6LRCrS66g@mail.gmail.com>
On 10/4/23 16:51, David Marchand wrote:
> - did you test with --in-memory mode? with --no-huge?
Please see v2 of the patch. I added checks for these options. They imply
no multi-process support so mapping is skipped for those cases.
> - I did not look at the patch, but I wonder if there is a risk some
> "local" ASan region (for the process heap, for example) can overlap
> with some "shared" ASan region (for shared DPDK hugepages).
I don't think it's possible unless the actual memory regions overlap.
The ASan shadow region is always at a fixed offset from the memory it
shadows. Also, this patch only makes the shadow regions shared, ASan
instrumentation already uses these regions.
> - with this work, would unit tests (that were marked failing with
> ASan) be ok now? See REGISTER_FAST_TEST macro in app/test.
I tried enabling these tests and some of them started passing with this
patch, namely:
- multiprocess_autotest
- eal_flags_c_opt_autotest
- eal_flags_main_opt_autotest
- eal_flags_a_opt_autotest
eal_flags_file_prefix_autotest still fails. The rest seem to be passing
even without the patch.
Regards,
Artur
next prev parent reply other threads:[~2023-10-09 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 14:23 Artur Paszkiewicz
2023-10-04 14:51 ` David Marchand
2023-10-09 11:05 ` Artur Paszkiewicz [this message]
2023-10-09 11:03 ` [PATCH v2] " Artur Paszkiewicz
2023-10-25 9:27 ` [PATCH v3] " Artur Paszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=def0cf1a-a2b6-4af5-9126-e9596f64455a@intel.com \
--to=artur.paszkiewicz@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).