From: longtb5@viettel.com.vn
To: <reshma.pattan@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] latency: clear mbuf timestamp after latency calculation
Date: Thu, 20 Sep 2018 19:16:05 +0700 (ICT) [thread overview]
Message-ID: <000101d450dc$caf26f20$60d74d60$@viettel.com.vn> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A39B0A6@IRSMSX109.ger.corp.intel.com>
Hi,
Thanks, I have sent a v2.
Any comment on the problem of dropped mbuf that I described in the cover
letter? In our application the max_latency_ns metric is useless since
after running for a while it would always take on obviously incorrect value
(up to a few minutes). I suspect the impact on avg_latency_ns is much less
severe but significant nonetheless.
> -----Original Message-----
> From: reshma.pattan@intel.com [mailto:reshma.pattan@intel.com]
> Sent: Thursday, September 20, 2018 5:25 PM
> To: longtb5@viettel.com.vn
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] latency: clear mbuf timestamp after latency
calculation
>
> Hi,
>
> > -----Original Message-----
> > From: longtb5@viettel.com.vn [mailto:longtb5@viettel.com.vn]
> > Sent: Wednesday, September 19, 2018 9:23 AM
> > To: Pattan, Reshma <reshma.pattan@intel.com>
> > Cc: dev@dpdk.org; Bao-Long Tran <longtb5@viettel.com.vn>;
> > stable@dpdk.org
> > Subject: [PATCH] latency: clear mbuf timestamp after latency
> > calculation
> >
> > The timestamp of a mbuf should be cleared after that mbuf was used for
> > latency calculation, otherwise future packets which reuse the same
> > mbuf would inherit that previous timestamp. The latencystats library
> > looks for mbuf with non-zero timestamp, thus incorrectly inherited
> > value would result in incorrect latency measurement.
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bao-Long Tran <longtb5@viettel.com.vn>
>
> You need to add the Fixes line just before CC: in the commit message.
>
> Original commit that introduced the bug was 5cd3cac9ed. So fixes should
be
> added like below
> Fixes: 5cd3cac9ed ("latency: added new library for latency stats").
>
> You can send v2 with fixes line and my ack. Other than that
>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
next prev parent reply other threads:[~2018-09-20 12:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 8:17 [dpdk-dev] Incorrect latencystats implementation longtb5
2018-09-19 8:22 ` [dpdk-dev] [PATCH] latency: clear mbuf timestamp after latency calculation longtb5
2018-09-20 10:25 ` Pattan, Reshma
2018-09-20 12:16 ` longtb5 [this message]
2018-09-20 11:16 ` [dpdk-dev] [PATCH v2] " longtb5
2018-09-20 13:08 ` [dpdk-dev] Incorrect latencystats implementation Pattan, Reshma
2018-09-21 1:58 ` longtb5
2018-09-21 11:15 ` Pattan, Reshma
2018-09-21 12:14 ` Ananyev, Konstantin
2018-09-21 14:58 ` Pattan, Reshma
2018-09-19 8:18 [dpdk-dev] [PATCH] latency: clear mbuf timestamp after latency calculation longtb5
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d450dc$caf26f20$60d74d60$@viettel.com.vn' \
--to=longtb5@viettel.com.vn \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).