From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 373BFA04BC; Fri, 9 Oct 2020 05:03:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1024B1BEC0; Fri, 9 Oct 2020 05:03:28 +0200 (CEST) Received: from smtpbg511.qq.com (smtpbg511.qq.com [203.205.250.109]) by dpdk.org (Postfix) with ESMTP id 3E3381BEC0 for ; Fri, 9 Oct 2020 05:03:24 +0200 (CEST) X-QQ-mid: bizesmtp26t1602212597tw26hna8 Received: from jiawenwu (unknown [183.129.236.74]) by esmtp10.qq.com (ESMTP) with id ; Fri, 09 Oct 2020 11:03:16 +0800 (CST) X-QQ-SSF: 01400000002000C0C000B00A0000000 X-QQ-FEAT: HLwgFh8nePok/jj53mpvD4WiN0iKtEREqZnP2Rf+jWnVUgDI311WQHlbFflO6 80217VnTQlpIP2uxi+yCLKBIrq6ZNxf2rwjAYz5n5a3Te9YeQ1GmIVwz8ylQwD+jzA4kjBd WYmD9mT2xPHCfsUmIIZWVBQWC6tjV2h+QpuKt3rAhT1yr2lU3B84lUXW8WYVx9WGz7RXtlj 01Gw9k014Nnw8uAc6QtSp9Pcj0D92mDgPu6FRTzWwmsNC+5MNOPUb74Dn8reegtig9t3slN fnRHaix/b9ttN5HAVs/1KPzES+KNMCXwONBcUhC55jTO9qFEhKnhrUdEzqacOqvCg4anr+9 owNdKOg X-QQ-GoodBg: 2 From: To: "'Ferruh Yigit'" , References: <20201005120910.189343-1-jiawenwu@trustnetic.com> <9111b3e0-45b7-922f-00d6-08ac0fbeedd7@intel.com> In-Reply-To: <9111b3e0-45b7-922f-00d6-08ac0fbeedd7@intel.com> Date: Fri, 9 Oct 2020 11:03:16 +0800 Message-ID: <000701d69de8$bc4880d0$34d98270$@trustnetic.com>+0A62351A059118A6 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHJlj4aCK0Iq8YnxyZPtDQE+bqN9QK1MPplqZL339A= Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v2 00/56] net: txgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, For the syntax/style check issue, should I fix all the errors and = warnings or just fix the errors? It seems to be a lot of warnings. -----Original Message----- From: Ferruh Yigit =20 Sent: Tuesday, October 6, 2020 7:03 PM To: Jiawen Wu ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 00/56] net: txgbe PMD On 10/5/2020 1:08 PM, Jiawen Wu wrote: > v2: re-order patches and fix some known problems > v1: introduce txgbe PMD >=20 > jiawenwu (56): > net/txgbe: add build and doc infrastructure > net/txgbe: add ethdev probe and remove > net/txgbe: add device init and uninit > net/txgbe: add error types and registers > net/txgbe: add mac type and bus lan id > net/txgbe: add HW infrastructure and dummy function > net/txgbe: add EEPROM functions > net/txgbe: add HW init and reset operation > net/txgbe: add PHY init > net/txgbe: add module identify > net/txgbe: add PHY reset > net/txgbe: add info get operation > net/txgbe: add interrupt operation > net/txgbe: add device configure operation > net/txgbe: add link status change > net/txgbe: add multi-speed link setup > net/txgbe: add autoc read and write > net/txgbe: add MAC address operations > net/txgbe: add unicast hash bitmap > net/txgbe: add RX and TX init > net/txgbe: add RX and TX queues setup and release > net/txgbe: add RX and TX start and stop > net/txgbe: add packet type > net/txgbe: fill simple transmit function > net/txgbe: fill transmit function with hardware offload > net/txgbe: fill TX prepare funtion > net/txgbe: fill receive functions > net/txgbe: add device start operation > net/txgbe: add RX and TX data path start and stop > net/txgbe: add device stop and close operations > net/txgbe: support RX interrupt > net/txgbe: add RX and TX queue info get > net/txgbe: add device stats get > net/txgbe: add device xstats get > net/txgbe: add queue stats mapping > net/txgbe: add VLAN handle support > net/txgbe: add SWFW semaphore and lock > net/txgbe: add PF module init and uninit for SRIOV > net/txgbe: add process mailbox operation > net/txgbe: add PF module configure for SRIOV > net/txgbe: add VMDq configure > net/txgbe: add RSS support > net/txgbe: add DCB support > net/txgbe: add flow control support > net/txgbe: add FC auto negotiation support > net/txgbe: add priority flow control support > net/txgbe: add device promiscuous and allmulticast mode > net/txgbe: add MTU set operation > net/txgbe: add FW version get operation > net/txgbe: add EEPROM info get operation > net/txgbe: add register dump support > net/txgbe: support device LED on and off > net/txgbe: add mirror rule operations > net/txgbe: add PTP support > net/txgbe: add DCB info get operation > net/txgbe: add Rx and Tx descriptor status >=20 Hi Jiawen, Before going into more detailed reviews, the patchset conflicts with = some recent changes in the main repo [1], can you please rebase on top = of the latest head of the repo? Also DPDK syntax/style check scripts are giving errors, can you please = fix them too? You should run following to check: ./devtools/checkpatches.sh -n56 ./devtools/check-git-log.sh -n56 (This one needs codespell package to show spelling errors) [1] mainly the list is: 1) PMD close behavior change, - .dev_close changes - RTE_ETH_DEV_CLOSE_REMOVE flag removed 2) Some dev_ops moved to ethdev struct - .rx_queue_count - .rx_descriptor_done - .rx_descriptor_status - .tx_descriptor_status