From: "Chao Zhu" <chaozhu@linux.vnet.ibm.com>
To: "'Thomas Monjalon'" <thomas@monjalon.net>,
"'Gowrishankar'" <gowrishankar.m@linux.vnet.ibm.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specific TSC freq query
Date: Wed, 7 Feb 2018 15:05:06 +0800 [thread overview]
Message-ID: <000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com> (raw)
In-Reply-To: <3728847.cnur1V9eyL@xps>
The previous patch has some misunderstanding of the the TSC frequency
counting.
I support this.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: 2018年2月1日 8:30
> To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>; Chao Zhu
> <chaozhu@linux.vnet.ibm.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal/ppc64: revert implement arch-specific
TSC
> freq query
>
> 30/01/2018 09:59, Gowrishankar:
> > From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> >
> > This reverts commit 15692396fd68932b6a81f00f12d4b0da12baa7d3
> > (eal/ppc64: implement arch-specific TSC freq query). We intended to
> > derive pkt/sec estimation with cpu clock frequency. As timebase
> > register serves the timer purpose, we need to stick with it for
> > calculating pkt/sec, hence reverting the change.
> >
> > Fixes: 15692396fd (eal/ppc64: implement arch-specific TSC freq query)
>
> It is not clear what it is fixing.
>
> Chao, please review.
next prev parent reply other threads:[~2018-02-07 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 8:59 Gowrishankar
2018-02-01 0:29 ` Thomas Monjalon
2018-02-07 7:05 ` Chao Zhu [this message]
2018-02-07 7:26 ` Thomas Monjalon
2018-02-07 7:46 ` Chao Zhu
2018-02-07 7:02 ` Chao Zhu
2018-02-08 21:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000901d39fe1$fcdfcde0$f69f69a0$@linux.vnet.ibm.com' \
--to=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).