From: "Chao Zhu" <chaozhu@linux.vnet.ibm.com>
To: "'Lukasz Majczak'" <lma@semihalf.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] librte_eal: fix wrong assert for arm and ppc
Date: Thu, 28 Sep 2017 10:01:43 +0800 [thread overview]
Message-ID: <000b01d337fd$bc6d4e50$3547eaf0$@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170925073441.23494-1-lma@semihalf.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lukasz Majczak
> Sent: 2017年9月25日 15:35
> To: dev@dpdk.org
> Cc: Lukasz Majczak <lma@semihalf.com>
> Subject: [dpdk-dev] [PATCH v3] librte_eal: fix wrong assert for arm and
ppc
>
> The assertion of return value from the open() function is done against 0,
while it
> is a correct value - open() returns -1 in case of an error.
> It causes problems while trying to run as a daemon, in which case, this
call to
> open() will return 0 as a valid descriptor.
>
> Fixes: b94e5c9406b5 ("eal/arm: add CPU flags for ARMv7")
> Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
> Fixes: 9ae155385686 ("eal/ppc: cpu flag checks for IBM Power")
>
> Signed-off-by: Lukasz Majczak <lma@semihalf.com>
> ---
> lib/librte_eal/common/arch/arm/rte_cpuflags.c | 2 +-
> lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/arch/arm/rte_cpuflags.c
> b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
> index 5636e9c1d..88f1cbe37 100644
> --- a/lib/librte_eal/common/arch/arm/rte_cpuflags.c
> +++ b/lib/librte_eal/common/arch/arm/rte_cpuflags.c
> @@ -137,7 +137,7 @@ rte_cpu_get_features(hwcap_registers_t out)
> _Elfx_auxv_t auxv;
>
> auxv_fd = open("/proc/self/auxv", O_RDONLY);
> - assert(auxv_fd);
> + assert(auxv_fd != -1);
> while (read(auxv_fd, &auxv, sizeof(auxv)) == sizeof(auxv)) {
> if (auxv.a_type == AT_HWCAP) {
> out[REG_HWCAP] = auxv.a_un.a_val;
> diff --git a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
> b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
> index fcf96e045..970a61c5e 100644
> --- a/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
> +++ b/lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c
> @@ -108,7 +108,7 @@ rte_cpu_get_features(hwcap_registers_t out)
> Elf64_auxv_t auxv;
>
> auxv_fd = open("/proc/self/auxv", O_RDONLY);
> - assert(auxv_fd);
> + assert(auxv_fd != -1);
> while (read(auxv_fd, &auxv,
> sizeof(Elf64_auxv_t)) == sizeof(Elf64_auxv_t)) {
> if (auxv.a_type == AT_HWCAP)
> --
> 2.14.1
Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
next prev parent reply other threads:[~2017-09-28 2:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 15:59 [dpdk-dev] [PATCH v2] " Lukasz Majczak
2017-09-22 8:31 ` Jan Viktorin
2017-09-25 7:34 ` [dpdk-dev] [PATCH v3] " Lukasz Majczak
2017-09-28 2:01 ` Chao Zhu [this message]
2017-09-28 6:54 ` [dpdk-dev] [PATCH v4] " Lukasz Majczak
2017-10-05 22:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000b01d337fd$bc6d4e50$3547eaf0$@linux.vnet.ibm.com' \
--to=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=lma@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).