From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 89F091BDE1 for ; Fri, 21 Dec 2018 14:31:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Dec 2018 05:31:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,381,1539673200"; d="scan'208";a="120232648" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by FMSMGA003.fm.intel.com with ESMTP; 21 Dec 2018 05:31:47 -0800 To: Andrew Rybchenko , =?UTF-8?Q?Ga=c3=abtan_Rivet?= Cc: dev@dpdk.org, Ivan Malov References: <1539344187-21481-1-git-send-email-arybchenko@solarflare.com> <585c9670-07b6-abfa-027d-e4d07febb7d4@intel.com> <969cb7e3-6e1a-f5ac-ed1b-e4334f928b17@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <000e1ce9-819e-a75c-cc51-0f6ddcbbb5be@intel.com> Date: Fri, 21 Dec 2018 13:31:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <969cb7e3-6e1a-f5ac-ed1b-e4334f928b17@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] net/failsafe: add default Tx mbuf fast free capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 13:31:50 -0000 On 12/21/2018 12:52 PM, Andrew Rybchenko wrote: > Hi Ferruh, > > On 12/21/18 3:43 PM, Ferruh Yigit wrote: >> On 12/21/2018 12:28 PM, Andrew Rybchenko wrote: >>> On 12/21/18 3:12 PM, Ferruh Yigit wrote: >>>> On 10/12/2018 12:36 PM, Andrew Rybchenko wrote: >>>>> From: Ivan Malov >>>>> >>>>> This capability is reported when supported by the current emitting >>>>> sub-device. Failsafe PMD itself does not excercise fast free logic. >>>> I think overlay device capability reporting already discussed a few times, the >>>> question is if an overlay devices should claim a feature when it depends on >>>> underlay devices? >>> The capability may be reported by the failsafe since it is transparent from >>> fast free logic point of view. >> Why it is transparent? If one of the underlying device doesn't support/claim >> this feature, application can't use this feature with failsafe, isn't it? > > tx_offload_capa in failsafe is a mask to apply on sub-device capabilities. I missed this one, I see why it is transparent. Why failsafe doesn't set a full tx_offload_capa MASK but maintain a list? > So, if the capability is not supported by any sub-device it will not be > reported. > As well if there is the capability bit in the mask, it will not be > reported regardless > sub-devices capabilities. The description for the patch above tries to > explain it - > it looks like not that successful. > >>>> Given that no ack/review given to the patch, I am updating it as rejected. >>> Is it a new policy? I thought that it was vice versa before. >> Hi Andrew, >> >> Yes policy is other-way around indeed, when there is no comment at all default >> behavior is accept, but please take above paragraph as my comment to the patch. > > Got it. > >> And I was thinking it is a little controversial and there is no support to have >> it, so lets don't get it. What do you think? > > I see you motivation. > >>>>> Signed-off-by: Ivan Malov >>>>> Signed-off-by: Andrew Rybchenko >>>>> --- >>>>> doc/guides/nics/features/failsafe.ini | 1 + >>>>> drivers/net/failsafe/failsafe_ops.c | 1 + >>>>> 2 files changed, 2 insertions(+) >>>>> >>>>> diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini >>>>> index e3c4c08f2..b6f3dcee6 100644 >>>>> --- a/doc/guides/nics/features/failsafe.ini >>>>> +++ b/doc/guides/nics/features/failsafe.ini >>>>> @@ -7,6 +7,7 @@ >>>>> Link status = Y >>>>> Link status event = Y >>>>> Rx interrupt = Y >>>>> +Fast mbuf free = Y >>>>> Queue start/stop = Y >>>>> Runtime Rx queue setup = Y >>>>> Runtime Tx queue setup = Y >>>>> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c >>>>> index 7f8bcd4c6..e3add404b 100644 >>>>> --- a/drivers/net/failsafe/failsafe_ops.c >>>>> +++ b/drivers/net/failsafe/failsafe_ops.c >>>>> @@ -78,6 +78,7 @@ static struct rte_eth_dev_info default_infos = { >>>>> DEV_RX_OFFLOAD_SECURITY, >>>>> .tx_offload_capa = >>>>> DEV_TX_OFFLOAD_MULTI_SEGS | >>>>> + DEV_TX_OFFLOAD_MBUF_FAST_FREE | >>>>> DEV_TX_OFFLOAD_IPV4_CKSUM | >>>>> DEV_TX_OFFLOAD_UDP_CKSUM | >>>>> DEV_TX_OFFLOAD_TCP_CKSUM | >>>>> > >