From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58788A04E7; Mon, 2 Nov 2020 10:11:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38224AC90; Mon, 2 Nov 2020 10:11:29 +0100 (CET) Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) by dpdk.org (Postfix) with ESMTP id 24777A9A0 for ; Mon, 2 Nov 2020 10:11:27 +0100 (CET) X-QQ-mid: bizesmtp23t1604308277tmzgyshb Received: from jiawenwu (unknown [183.129.236.74]) by esmtp10.qq.com (ESMTP) with id ; Mon, 02 Nov 2020 17:11:16 +0800 (CST) X-QQ-SSF: 00400000002000C0C000B00A0000000 X-QQ-FEAT: YRafYbOWhSDkFTvW0+k0jSPJ6J/8H8/HHiyI+8hE+Az15UuTtlpJLI3sPvlrk K2DoaqMPKcp5kdM07MnlNZuZ0R/lNGnJwUTizb3JRM1AYaMbuN01fnT8tOl661Vc60qIxdc bOD8FAGL4SdRa9b0V01rE9vCL518p/vRSqgFJ/rA5eeRPfyWOvAWhFIFumz2A4Q97k23F12 axQulAeV7FvFAhrcwzrrxpC+iqJ8cXvXSFgO8v9EALscuWlsMP6xcSdaVlw3alPzN4kTHyo KGJkhzkrYghXSUAWOF7A4NWe+8nX9UxeoOSAyI8656q1soEDAM/+V8zqBoJwKE0wOfNA== X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'David Marchand'" , "'Thomas Monjalon'" , "'Ferruh Yigit'" Cc: "'Jian Wang'" , "'dev'" , "'Bruce Richardson'" , "'Olivier Matz'" , "'Andrew Rybchenko'" , "'Akhil Goyal'" , "'Jerin Jacob Kollanukkaran'" References: <20201026052105.1561859-1-thomas@monjalon.net> <16204738.pLQXvH3U5b@thomas> <5960b0cf-eb7a-af00-ae6a-86ad5e5db6eb@intel.com> <2336246.PS5YtoHrA8@thomas> In-Reply-To: Date: Mon, 2 Nov 2020 17:11:16 +0800 Message-ID: <002501d6b0f8$1f5d1420$5e173c60$@trustnetic.com>+732BCBF459C502E4 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIP3CVm74Z6lO/tF7tx1HGgdOYnaAI+v+zzAekoglICQldiUgHSOjpEqQBSl+A= Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH v6 00/15] remove mbuf userdata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sunday, November 1, 2020 6:26 PM, David Marchand wrote: > On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon > wrote: > > > The new txgbe driver in the next-net is also using = =E2=80=98udata64=E2=80=99, that > > > also needs to be updated. cc'ed txgbe maintainer. > > > > That's a pity it did not take into account the deprecation notice. > > What kind of hack is it used for? > > Can it be simply removed to allow quick merging of the PMD? >=20 > +1 for removing. >=20 > It seems to be a provision for future features, as this field is = simply passed to > an internal function that does not use it. >=20 > $ git grep -C 2 udata drivers/net/txgbe/ > drivers/net/txgbe/txgbe_rxtx.c- > drivers/net/txgbe/txgbe_rxtx.c- > txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, > drivers/net/txgbe/txgbe_rxtx.c: > tx_offload, &tx_pkt->udata64); > drivers/net/txgbe/txgbe_rxtx.c- > drivers/net/txgbe/txgbe_rxtx.c- txe->last_id = =3D > tx_last; >=20 > $ git grep -C 2 txgbe_set_xmit_ctx drivers/net/txgbe/ > drivers/net/txgbe/txgbe_rxtx.c- > drivers/net/txgbe/txgbe_rxtx.c-static inline void > drivers/net/txgbe/txgbe_rxtx.c:txgbe_set_xmit_ctx(struct = txgbe_tx_queue > *txq, > drivers/net/txgbe/txgbe_rxtx.c- volatile struct > txgbe_tx_ctx_desc *ctx_txd, > drivers/net/txgbe/txgbe_rxtx.c- uint64_t ol_flags, union > txgbe_tx_offload tx_offload, > -- > drivers/net/txgbe/txgbe_rxtx.c- } > drivers/net/txgbe/txgbe_rxtx.c- > drivers/net/txgbe/txgbe_rxtx.c: > txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, > drivers/net/txgbe/txgbe_rxtx.c- > tx_offload, &tx_pkt->udata64); > drivers/net/txgbe/txgbe_rxtx.c- >=20 > $ git grep -w mdata drivers/net/txgbe/ > drivers/net/txgbe/txgbe_rxtx.c: __rte_unused uint64_t *mdata) >=20 >=20 > -- > David Marchand Thanks for review. It can be just simply removed in txgbe driver.