From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8529541E2E; Wed, 8 Mar 2023 16:28:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37434410EE; Wed, 8 Mar 2023 16:28:37 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2047.outbound.protection.outlook.com [40.107.101.47]) by mails.dpdk.org (Postfix) with ESMTP id 30C8F40FAE; Wed, 8 Mar 2023 16:28:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f3Ut42+anNMwtFegFo8ZIpVqx2U3yb5HvsvSfSkH2ZX9yc0s87xo8inncnneqBECmL1/J6KkQKjNFRm0m42gNSeehZyl2Y3GITuM8wqhVnwkvCb2nme6Djl12z0gmYN2z7YaC9PmFWUuk3/ZBMaUXmfbOFYuAtvRk8l2CEw+/BxxqDwUkWklvLQ7CnUw8TuW3ATmiRtUluc+2sxfYf3hTu05w+ImBJSOqsRkvw2DVDvm4l0dEQslW35XsMZyR5D+KxnPbZVIvD93TRSgBGvYrd0URr9CVIPq60FIQ9S3uQJ6cLBaPgydYDbIam5eFOslo92Im+XWOy2MCZKLuVUTSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cd8Gp1lETRRiM/PzuuhTfGwUfpzKZQ56EA4Lw6cqQZ8=; b=h0phYJG5G+2QmMj7n1bmcr1OOHtnAlCC5RcbWzYow2G2/QmcYE+zo46AodOQ2lTwQLFAK4kpR1DkIYlDUqeLe3Z1+DuDhrNFaBppc7s6k0I2VWsN3/RaGJ0Iobzo888sQOdppanuN9GDIPsOZ4hSnz+03w0Ss8aryoZOSII8WOhUd+dp958mkngiz3w3NhPhTsQgnrImHb1G8FDAtHEEYBv4VwwNVGX9qOR3O/MIrwhc/P1AEGzO9/BZpoXuXOhmmICGctkhR4NxUoMczZwyNM+NU8gCyn2pMYptmgPl1rAVLplx1ThExg9/LoNVt3/6+kvLXDyMyLh1AzIilx0oSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cd8Gp1lETRRiM/PzuuhTfGwUfpzKZQ56EA4Lw6cqQZ8=; b=c+M8P/pJ3xH19rz8pLTrUX9ZCei24KQqQfGDfMcBwnCmDgnFeE6gwI6kyoXVxsAOMmDWebxNvv/SKMlZCVnzWPL3dJlwoJfcWc/3DwMLX2JC+7kY8qWD3PhRjFynN8iXJbEudglzCYPqIx4CzSMZEgMkSLAUOgI8aeD4N7fAw7g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4309.namprd12.prod.outlook.com (2603:10b6:610:a4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Wed, 8 Mar 2023 15:28:33 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%4]) with mapi id 15.20.6156.029; Wed, 8 Mar 2023 15:28:33 +0000 Message-ID: <002f73ff-730c-8566-223c-4e3c8702e7af@amd.com> Date: Wed, 8 Mar 2023 15:27:35 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] net/nfp: fix MTU configuration order Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Peng Zhang , stable@dpdk.org References: <20230308023318.3041151-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230308023318.3041151-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0530.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4309:EE_ X-MS-Office365-Filtering-Correlation-Id: 08b9bdde-5911-4371-02ae-08db1fe9c6e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ttpl/E+fQfZD2icVjew1fE+iVscDSQIrh4yKjS5MzNeHpUpfhGg34RcWnIy7Lddz93W2CyU10QrPIbOErvJgMQf4baDCCf5zz6NfHs+dMLYCfqVGl9a9w0QL6G/og2v/fB8oWtJyMYV0wEfQXPk1ejEWYzAnjFGTfNRf1dvg4O86vXK+5/E9P+I2v0Wxxhp2bK/GGdlOC6azpMIwzhtFBXdOOOX6VKK/2zqJk/Ef7sNts9iaK3gIAVyDkUgdDAcIONExS1SDgbwvTrc5HvThXnskWUAf0yiljakKuUXSZR3P8RwhSPeF5ydDpCEAPKTdIscqYCTKKKsSx1coC2ftr8HHCc51OH/9g4qOwbboM/fl0hTOFzD/dhk5URQoID2LHB2nrbJA9r8sCZmO66sym78n3yQ4abtEltbarkY22/Lv3mlTBZOdm9dOIRB7lz6rr7+gdx5qH4IIp4eHcii/f0SNS7KHbthfOTJDQvG+ZQY7ArRB0OlqYEseKzgwS8KVdEiNhRbesXOIzPCHdNt6Lz3p7+6zov5ie2lO/iR81tBAkH4VleEe3Y2sBtPMy6/zdmrlRzRzdPgsmaw8/w+BdzTX6P3DFc5gJuJUm46ZqC+Fdk3yhpcRkz0syXEdHeZgJGYaxolHy8ITi//I3AFweIxtGvrwaFSLdnqu8NwsA07czumy7RhM3m+FnLSFkzwKVatNSEFzNnnicBz66tyWsbIE8ZVjJwbSGQM+ZC7sHro= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(451199018)(8936002)(6486002)(66476007)(8676002)(66556008)(4326008)(66946007)(5660300002)(2906002)(4744005)(44832011)(316002)(478600001)(86362001)(53546011)(186003)(6512007)(26005)(6506007)(31696002)(2616005)(36756003)(38100700002)(41300700001)(31686004)(66574015)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aFRuYVlVS2Y3V3FIQmt5QkRNejdYUEw1TVdzRWFPYUtrSTNEU015c0JkWEZ4?= =?utf-8?B?NnNEUlAralBYVFczcFBxb1E5ZlozV1dOQVFUR211THhSRlIvaXQwczMrL2Nk?= =?utf-8?B?cTNkdXdSOFlkZ1RIeHZ0VStSUHFZK1ZKcHA3VXJWN2JJUDgyUlcvMnExZ0RO?= =?utf-8?B?MjlMaEtOL2NLTmdDN2hMYzNDaExkVER0THpYelNkeElMRml6MWFoK1NWU20r?= =?utf-8?B?cXMvNTNER2FWQTF3YW9BZlhuUlVqWHFwQmhwRnFHb2NyRGljT3RmRCtnTE5Z?= =?utf-8?B?ZUsrS1dVUldKQ0tEdUVycm9SKy8xTlpTajQrNnBDNGhUM3JnV2lQK3VLUWFL?= =?utf-8?B?eEx5a3h3aGFVaWNVcVNtZ2QyK28xSXJwOVNuR3BJbXhobmVBbkF0aTdVUk1q?= =?utf-8?B?d1B0anI3aVFvaForS1VOK0FWMXhGNjk1VXhUY2JOOG5XbS91MmhObVpmeGNJ?= =?utf-8?B?UjIyRDNQM0x4eGhoWFBWQWdSd25kU0xPd0dxRXh2QzkyVExzTlJhTHU3YmNk?= =?utf-8?B?TDFJRkw4L3AwTCs0R0RVUDkrdkRBY3pOV1RzRE1CcWttcEk1alA3SHV5UWJF?= =?utf-8?B?RTlTQnovUEZHUm85WE5ITG5hcGRyYmhLaWJWd0xxcUdNS1UvT3ROVWc5OWto?= =?utf-8?B?cHBuVlYzNzBrQzF4SklKSWNPRXh3Z3hqcDR1WUVBUFhWQU1DQmg1eXc5Q1Q0?= =?utf-8?B?NWxKNWtxZWlNL0RodXI3dFo3VlhueDk0TWVLMGxDTlZ4Qk9ZdGl4dG9ndHNT?= =?utf-8?B?N0JvWEliWVRCRU1vZEZMRnJmRVVCL3Q2Y3ZvaUM5OUZkVlpJTjVsR2VsdGNB?= =?utf-8?B?RWgyNHFETGQ5dC96Wis4SWRKaTJkY0xXTzlHMkNSZG9NYTA1K3lhTjhlR2Ji?= =?utf-8?B?WkxsenUxWktxYytDVU81a1Fxb3NHYWVoemNlZmdMSkk0dDlLWG04c05qQ0dE?= =?utf-8?B?Z25JYnpMQ25MZHFhNEtiYXNFKzEvUlc0RVVqWDExcGcvMTJ3a1hlenlBeEZC?= =?utf-8?B?bjcwSDh4bFc2dkJTL0NLNHVjK3YrQTRkWFZ2a1VaWEVvRnZYNSsvK2FQWDNn?= =?utf-8?B?dXF5QVg3bFh0VnRzQ1hZbzNWT2Nld1JLYXpPVWh6R2VkQkJxdHFMc3V5eHFY?= =?utf-8?B?UGtuZjl4bnBENHdrNTFNbXRtdHh3MVB1eWxWekdLMTBSVXgreGVSSC81MWJu?= =?utf-8?B?c1JDOE91QXFPY1hvaGpHNG5LL1FRZUFzMWJ2VTJHYk94bHVHSndsRFNIMDNW?= =?utf-8?B?M1BiSGt5MHdSUzBtdTZiNnhzcUZmd3prc2VobisyNjFUMUVJcDcrVjFEOXZt?= =?utf-8?B?WTlTeFVYSnlzTHZ3Rm1CejBYaDlUTjNOV2tSWTRLdkhPQWZKNk9TQlc3Wm5l?= =?utf-8?B?WXFFLytuVU5ybnJQd25XSVMwelhBWlN1OGZ4WjgwL1R6bzNiNnFOYmdSU0NK?= =?utf-8?B?VWtoYis0VHVKSDFKUEYxNTYvUHNLVGY0dUduVFpmNmtuM0sxbW1Xd3EwdSts?= =?utf-8?B?eml6cTFzVUhVUG4vc2F1Wm11VlF3TW1pdWt6MlFrcGVOK1NGODUvbmZMQjhm?= =?utf-8?B?REtnYStXTE93NTRrVXppeTYrM0xEZHRPMTJsN1RHbjljVEYrcVRaT0h5VnVS?= =?utf-8?B?VzY2Sng0UlJVYVZENUlHOW81Rjg3TXNGbFg2QzdFRUVDaWZHOFl1SHVHRGN6?= =?utf-8?B?eHlzNEJDNHlsUkxBN0xJQkk0aXltdDZJanJkUWpPcnpjUTdLQzB5SWNpL29j?= =?utf-8?B?K2ZTM3VRYWtkdzFQZ3VNNzZxdWd0SDNZM0g4ZUI1RnBBSitqcWJhUzl3UHk3?= =?utf-8?B?Nm44QitkUWxXc2lXVFNNY01LUEJVSTF2bEx2VHROQVl6eWpZUW5Pd1IwNGhG?= =?utf-8?B?c2lOU29HMk5hbCtSWmZycVZZV1VvNHE1Ulowd2V2QXJNM09zUHM5b3djRW1i?= =?utf-8?B?ZGh1NzJ0Z0NTNTJPOEVkNDZ1Tm8rekwxL2RxbFcvTUhRTHkyTEpCV0YwaXNH?= =?utf-8?B?NXhBYVhpcXlkNzJva2krRlN5eWFZS3BIUVp2Q3IvZGNHL0QzWjBGNnlmd01R?= =?utf-8?B?aTlNeTQyamVkUGVJOXE4WjRXMGQwUDVSV2d4QjFhZ1BNd2dKK2tCL3lTYkRl?= =?utf-8?Q?/fH8nbCXS7XvLUcmH9aQVAe/a?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08b9bdde-5911-4371-02ae-08db1fe9c6e7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 15:28:33.0426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8D5MKv6lx3woM5P9M0QLerv4L9VPzqpWRjAAz0VVLBzQqKceu/Ewn1uztzbhnWVb X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4309 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/8/2023 2:33 AM, Chaoyong He wrote: > From: Peng Zhang > > If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the > NFP driver setup fails. This is because the default values evaluated > when setting the MTU are initialized in the rte_eth_rx_queue_setup() > code path. Fix this by instead initializing the MTU default values in > the device initialization, in nfp_net_init() and the check also is > conducted in nfp_net_start(), so it doesn't influence the result. > > This was found by using DPDK with OVS. > > Fixes: dbad6f64f921 ("net/nfp: fix internal buffer size and MTU check") > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund Applied to dpdk-next-net/main, thanks.