From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by dpdk.org (Postfix) with ESMTP id BE3E05A1F for ; Thu, 31 Dec 2015 13:44:22 +0100 (CET) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O08000QQ3DXTY70@mailout3.w1.samsung.com> for dev@dpdk.org; Thu, 31 Dec 2015 12:44:21 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-7e-56852325ec1f Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id E8.F3.16778.52325865; Thu, 31 Dec 2015 12:44:21 +0000 (GMT) Received: from fedinw7x64 ([106.109.131.169]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O0800MCG3DWNM60@eusync4.samsung.com>; Thu, 31 Dec 2015 12:44:21 +0000 (GMT) From: Pavel Fedin To: "'Tan, Jianfeng'" , dev@dpdk.org References: <002a01d142e6$fbfeb4e0$f3fc1ea0$@samsung.com> <002401d143af$38a6fa60$a9f4ef20$@samsung.com> <002c01d143b7$568aace0$03a006a0$@samsung.com> In-reply-to: Date: Thu, 31 Dec 2015 15:44:19 +0300 Message-id: <003901d143c8$f8472f70$e8d58e50$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQG9CCSBEyyw7dOXpyvuWj3KD0VyOAKSxP3UAeaqL4ICeMdKeAFj1QbGAeJKf/Oeu76xYA== Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t/xa7qqyq1hBn1XBSzefdrOZNE9+wub A5PHrwVLWT0W73nJFMAUxWWTkpqTWZZapG+XwJWxfs98toL/bBUrHq5jb2DcztrFyMkhIWAi Me/0bDYIW0ziwr31QDYXh5DAUkaJTa9esUA43xkl7rw4wgxSxSagLnH66wcWEFtEwEbi5fQ9 YJOAipgkXn4xBbE5BcIkLh/exQhiCwvYSXz/fBWsnkVAVWLe1Sb2LkYODl4BS6A5lSBhXgFB iR+T74GVMAtoSazfeZwJwpaX2LzmLTPEcQoSO86+ZoRYGyFxa8p8NogaEYlp/+4xT2AUnIVk 1Cwko2YhGTULScsCRpZVjKKppckFxUnpuYZ6xYm5xaV56XrJ+bmbGCFh/GUH4+JjVocYBTgY lXh4F6S1hAmxJpYVV+YeYpTgYFYS4bUvBgrxpiRWVqUW5ccXleakFh9ilOZgURLnnbvrfYiQ QHpiSWp2ampBahFMlomDU6qBkV3S4uP8BvOqpccFmQS86m6uqnuya47J60nv+hSj0/SuLiqT FnfoS3s6++vJUN09Pdvz5Gb+fCTw2ZBJRafRYdF06f1XXlZx7vw4YXPkUdXFXi9Fbvw8EFLN 0HNm0b7+Rw9PtC6PsVyusttc8HyGc/sbL6Ob9al33pR4iSw5d+Vosqnwq0nMf5RYijMSDbWY i4oTAS0llFJfAgAA Subject: Re: [dpdk-dev] [RFC 0/5] virtio support for container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2015 12:44:22 -0000 Hello! > > a) ovs_in_container does not send VHOST_USER_SET_MEM_TABLE > Please check if rte_eth_dev_start() is called. > (rte_eth_dev_start -> virtio_dev_start -> vtpci_reinit_complete -> kick_all_vq) > > > b) set_vring_addr() does not make sure that dev->mem is set. > > I am preparing a patch to fix (b). > > Yes, it seems like a bug, lack of necessary check. I've made some progress about (a). It's tricky. This caused by this fragment: if (vhost_user_read(vhost->sockfd, &msg, len, fds, fd_num) < 0) return 0; Here you ignore errors. And this particular request for some reason ends up in EBADF. The most magic part is that sometimes it just works... Not sure if i can finish it today, and here in Russia we have New Year holidays until 11th. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia