DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/txgbe: remove direct use of compiler attribute
Date: Tue, 10 Nov 2020 10:09:09 +0800
Message-ID: <004801d6b706$7a28cf70$6e7a6e50$@trustnetic.com> (raw)
In-Reply-To: <69bbfac6-8357-b55b-2426-5e658eef32b9@intel.com>

On Tuesday, November 10, 2020 3:19 AM, Ferruh Yigit wrote:
> On 11/9/2020 7:43 AM, Jiawen Wu wrote:
> > Remove direct use of compiler attribute.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > ---
> >   drivers/net/txgbe/base/txgbe_dummy.h | 2 +-
> >   drivers/net/txgbe/base/txgbe_osdep.h | 6 ++----
> >   2 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/txgbe/base/txgbe_dummy.h
> > b/drivers/net/txgbe/base/txgbe_dummy.h
> > index 0a3a76d0c..3a667dd31 100644
> > --- a/drivers/net/txgbe/base/txgbe_dummy.h
> > +++ b/drivers/net/txgbe/base/txgbe_dummy.h
> > @@ -7,7 +7,7 @@
> >
> >   #ifdef TUP
> >   #elif defined(__GNUC__)
> > -#define TUP(x) x##_unused __attribute__((unused))
> > +#define TUP(x) (x##_unused txgbe_unused)
> 
> Because of build error, removing parenthesis while applying, please double
> check ci build results of the patches [1] and send new version if required.
> Were there any specific reason for the parenthesis, am I missing something
> there?
> 

The parentheses are because of the checkpatch error [1].
But I forgot to build the project again when parentheses added.

[1]
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses

> [1]
> http://mails.dpdk.org/archives/test-report/2020-November/165922.html
> 
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied to
> dpdk-next-net/main, thanks.




      reply	other threads:[~2020-11-10  2:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09  7:43 Jiawen Wu
2020-11-09 19:18 ` Ferruh Yigit
2020-11-10  2:09   ` Jiawen Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004801d6b706$7a28cf70$6e7a6e50$@trustnetic.com' \
    --to=jiawenwu@trustnetic.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git