From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EDE18A052A;
	Tue, 10 Nov 2020 03:09:19 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C6CAFA8E9;
	Tue, 10 Nov 2020 03:09:17 +0100 (CET)
Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142])
 by dpdk.org (Postfix) with ESMTP id 2D79A72E2
 for <dev@dpdk.org>; Tue, 10 Nov 2020 03:09:15 +0100 (CET)
X-QQ-mid: bizesmtp4t1604974150tynjri80h
Received: from jiawenwu (unknown [183.129.236.74])
 by esmtp6.qq.com (ESMTP) with 
 id ; Tue, 10 Nov 2020 10:09:09 +0800 (CST)
X-QQ-SSF: 01400000002000C0C000B00A0000000
X-QQ-FEAT: qpmKYphpahlhx7goGIuwmtDBFOMk/NRNgf6FUJmFc6C68Hhg/M02NaJuIOg46
 X3+pqUS5CJRUWJ326+ALFHrmDPwfWn++qicknwnYf50PFpjvLGLM1kjFwB05Ut3dRHGil2D
 Lq0BWqiktEY8YsORG9wirO2LUjrj00+TR8mElLCxTRX+VguyN9x/ZPPIP3plYPes12PDFzb
 j3LTR/GUsr8DvKIbvtT1XQGO2imt9u/5kboGuCI/2+xGuXWFfX+NOjQrLIyHGkyH/SOrPFY
 pM5N1MPSja0XZKWJPumbx15fYZ66yWSMD9B6+t0qqFYctoe3erL0EuansFYayn9mBXGIPGf
 nZ+nzNf
X-QQ-GoodBg: 2
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@intel.com>,
	<dev@dpdk.org>
References: <20201109074346.3896752-1-jiawenwu@trustnetic.com>
 <69bbfac6-8357-b55b-2426-5e658eef32b9@intel.com>
In-Reply-To: <69bbfac6-8357-b55b-2426-5e658eef32b9@intel.com>
Date: Tue, 10 Nov 2020 10:09:09 +0800
Message-ID: <004801d6b706$7a28cf70$6e7a6e50$@trustnetic.com>+FB937D124FD10448
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGh846A1IJKhpwSCyhcTOBWjFtoawLHbOpwqhPmkqA=
Content-Language: zh-cn
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5
X-QQ-Bgrelay: 1
Subject: Re: [dpdk-dev] [PATCH] net/txgbe: remove direct use of compiler
	attribute
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tuesday, November 10, 2020 3:19 AM, Ferruh Yigit wrote:
> On 11/9/2020 7:43 AM, Jiawen Wu wrote:
> > Remove direct use of compiler attribute.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > ---
> >   drivers/net/txgbe/base/txgbe_dummy.h | 2 +-
> >   drivers/net/txgbe/base/txgbe_osdep.h | 6 ++----
> >   2 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/txgbe/base/txgbe_dummy.h
> > b/drivers/net/txgbe/base/txgbe_dummy.h
> > index 0a3a76d0c..3a667dd31 100644
> > --- a/drivers/net/txgbe/base/txgbe_dummy.h
> > +++ b/drivers/net/txgbe/base/txgbe_dummy.h
> > @@ -7,7 +7,7 @@
> >
> >   #ifdef TUP
> >   #elif defined(__GNUC__)
> > -#define TUP(x) x##_unused __attribute__((unused))
> > +#define TUP(x) (x##_unused txgbe_unused)
>=20
> Because of build error, removing parenthesis while applying, please =
double
> check ci build results of the patches [1] and send new version if =
required.
> Were there any specific reason for the parenthesis, am I missing =
something
> there?
>=20

The parentheses are because of the checkpatch error [1].
But I forgot to build the project again when parentheses added.

[1]
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in =
parentheses

> [1]
> http://mails.dpdk.org/archives/test-report/2020-November/165922.html
>=20
>=20
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied to
> dpdk-next-net/main, thanks.