From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 802228E5E for ; Wed, 16 Dec 2015 12:57:18 +0100 (CET) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NZG00E1D97GWC80@mailout4.w1.samsung.com> for dev@dpdk.org; Wed, 16 Dec 2015 11:57:16 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-32-5671519c9302 Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id B1.25.16778.C9151765; Wed, 16 Dec 2015 11:57:16 +0000 (GMT) Received: from fedinw7x64 ([106.109.131.169]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NZG00MPX97F1Y90@eusync2.samsung.com>; Wed, 16 Dec 2015 11:57:16 +0000 (GMT) From: Pavel Fedin To: 'Yuanhan Liu' References: <20151215082324.GG29571@yliu-dev.sh.intel.com> <007f01d13715$042a0a80$0c7e1f80$@samsung.com> <20151215100548.GD32243@pxdev.xzpeter.org> <00b601d13733$97e063a0$c7a12ae0$@samsung.com> <20151215133612.GJ29571@yliu-dev.sh.intel.com> <00ca01d1373f$3dd4ab30$b97e0190$@samsung.com> <20151215135907.GK29571@yliu-dev.sh.intel.com> <00f101d13749$0eb97330$2c2c5990$@samsung.com> <20151216072818.GO29571@yliu-dev.sh.intel.com> In-reply-to: <20151216072818.GO29571@yliu-dev.sh.intel.com> Date: Wed, 16 Dec 2015 14:57:15 +0300 Message-id: <005501d137f8$e89c0090$b9d401b0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQK9V+xZvGxsIzDMyoR6pA/r8KpXSwDW318ZAtSKM5UBeJxtUQIgQOPQAk2OOfsCgD5cQwHQRbSoAdgp638BvTr+8AKKQ6eYnFUw3CA= Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xK7pzAgvDDKb3KVm8+7SdyWLL/m/s Ft0999gtFh84zGxxfcIFVgdWj4v9dxg9fi1Yyuox72Sgx/t9V9kCWKK4bFJSczLLUov07RK4 Mhqn97AUrOaoWNq1i6mB8QJbFyMnh4SAicSV5Z3sELaYxIV764HiXBxCAksZJU6ef8YK4Xxn lJjy+yorSBWbgLrE6a8fWEBsEQF9iU9bW1lAipgFuhgluqfMY4boOMEiMXHOI7AdnALWEqub D4F1CAv4Srxc+oQJxGYRUJXYdPwN2G5eAUuJyd3rWCFsQYkfk++B1TMLaEms33mcCcKWl9i8 5i0zxK0KEjvOvmaEuKJC4talt2wQNSIS0/7dY57AKDQLyahZSEbNQjJqFpKWBYwsqxhFU0uT C4qT0nMN9YoTc4tL89L1kvNzNzFCouLLDsbFx6wOMQpwMCrx8F6ILAgTYk0sK67MPcQowcGs JML7UK4wTIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv3F3vQ4QE0hNLUrNTUwtSi2CyTBycUg2M kqv0tzkwdC7IZq8xPM+39JzLvXgWy/d3bsZ16gnO0KmftODAs67/fRcvL5giMW31v7K9jk/3 rOq2+WV6+VB41CPdyO7FLWp1aYUcQKvmCXk9+V32enNOZd37AB1Vw6nyKo1VNUt29Jv93VAw d094c8gBC7em8jD7E0+ZnsoxCrcHCoev11NiKc5INNRiLipOBABK430BhgIAAA== Cc: dev@dpdk.org, 'Victor Kaplansky' Subject: Re: [dpdk-dev] [PATCH 0/4 for 2.3] vhost-user live migration support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2015 11:57:18 -0000 Hello! > I can reproduce your issue on my side with above patch (and only when > F_GUEST_ANNOUNCE is not set at DPDK vhost lib). TBH, I don't know > why that happened, the cause could be subtle, and I don't think it's > worthwhile to dig it, especially it's not the right way to do it. May be not right, may be it can be done... Actually, i found what was wrong. qemu tries to feed features back to vhost-user via VHOST_USER_SET_FEATURES, and DPDK barfs on the unknown bit. More tweaking is needed for qemu to do the trick correctly. > So, would you please try to set the F_GUEST_ANNOUNCE flag on DPDK vhost > lib side, as my early diff showed and have another test? Tried it, works fine, thank you. I have almost implemented the workaround in qemu... However now i start to think that you are right. Theoretically, the application may want to suppress GUEST_ANNOUNCE for some reason. So, let it stay this way. Please include this bit into your v2. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia