From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id BD85237B4
 for <dev@dpdk.org>; Mon, 25 Sep 2017 14:06:47 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 25 Sep 2017 05:06:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,436,1500966000"; d="scan'208";a="903585710"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57])
 ([10.237.220.57])
 by FMSMGA003.fm.intel.com with ESMTP; 25 Sep 2017 05:06:45 -0700
To: Zhiyong Yang <zhiyong.yang@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, adrien.mazarguil@6wind.com
References: <20170921083243.57991-1-zhiyong.yang@intel.com>
 <20170925032231.72897-1-zhiyong.yang@intel.com>
 <20170925032231.72897-3-zhiyong.yang@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <005b9d04-75b6-4673-57d2-d1b09e83ef6d@intel.com>
Date: Mon, 25 Sep 2017 13:06:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170925032231.72897-3-zhiyong.yang@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Sep 2017 12:06:48 -0000

On 9/25/2017 4:22 AM, Zhiyong Yang wrote:
> Extend port_id definition from uint8_t to uint16_t in lib and drivers
> data structures, specifically rte_eth_dev_data. Modify the APIs,
> drivers and app using port_id at the same time.
> 
> Fix some checkpatch issues from the original code and remove some
> unnecessary cast operations.
> 
> release_17_11 and deprecation have been updated in this patch.
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

<...>

> diff --git a/drivers/net/af_packet/Makefile b/drivers/net/af_packet/Makefile
> index 70d517c16..4d62b7dbd 100644
> --- a/drivers/net/af_packet/Makefile
> +++ b/drivers/net/af_packet/Makefile
> @@ -40,7 +40,7 @@ LIB = librte_pmd_af_packet.a
>  
>  EXPORT_MAP := rte_pmd_af_packet_version.map
>  
> -LIBABIVER := 1
> +LIBABIVER := 2

I have just recognized this one. This shouldn't be updated. Only
LIABIVER of the libraries that their API modified should be updated.

The release notes "Shared Library Versions" updates and Makefile
LIBABIVER updates should be compatible. I mean either both needs to be
updated or both not updated.

There is no way to split this patch more without breaking build right?
It would be possible to do it if port_t used, but that has been decided
not to...

<...>