DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Ferruh Yigit'" <ferruh.yigit@intel.com>,
	"'Igor Russkikh'" <igor.russkikh@aquantia.com>,
	"'Pavel Belous'" <pavel.belous@aquantia.com>,
	"'Somalapuram Amaranath'" <asomalap@amd.com>,
	"'Ajit Khaparde'" <ajit.khaparde@broadcom.com>,
	"'Somnath Kotur'" <somnath.kotur@broadcom.com>,
	"'Hemant Agrawal'" <hemant.agrawal@nxp.com>,
	"'Sachin Saxena'" <sachin.saxena@oss.nxp.com>,
	"'Jeff Guo'" <jia.guo@intel.com>,
	"'Haiyue Wang'" <haiyue.wang@intel.com>,
	"'John Daley'" <johndale@cisco.com>,
	"'Hyong Youb Kim'" <hyonkim@cisco.com>,
	"'Min Hu \(Connor\)'" <humin29@huawei.com>,
	"'Yisen Zhuang'" <yisen.zhuang@huawei.com>,
	"'Lijun Ou'" <oulijun@huawei.com>,
	"'Beilei Xing'" <beilei.xing@intel.com>,
	"'Qiming Yang'" <qiming.yang@intel.com>,
	"'Qi Zhang'" <qi.z.zhang@intel.com>,
	"'Andrew Boyer'" <aboyer@pensando.io>,
	"'Jerin Jacob'" <jerinj@marvell.com>,
	"'Nithin Dabilpuram'" <ndabilpuram@marvell.com>,
	"'Kiran Kumar K'" <kirankumark@marvell.com>,
	"'Rasesh Mody'" <rmody@marvell.com>,
	"'Devendra Singh Rawat'" <dsinghrawat@marvell.com>,
	"'Andrew Rybchenko'" <andrew.rybchenko@oktetlabs.ru>,
	"'Jian Wang'" <jianwang@trustnetic.com>,
	"'Thomas Monjalon'" <thomas@monjalon.net>,
	"'Selwin Sebastian'" <selwin.sebastian@amd.com>,
	"'Remy Horton'" <remy.horton@intel.com>,
	"'Chunsong Feng'" <fengchunsong@huawei.com>,
	"'Huisong Li'" <lihuisong@huawei.com>,
	"'Hao Chen'" <chenhao164@huawei.com>,
	"'Wei Hu \(Xavier\)'" <xavier.huwei@huawei.com>,
	"'Jingjing Wu'" <jingjing.wu@intel.com>,
	"'Wenzhuo Lu'" <wenzhuo.lu@intel.com>,
	"'Xiaoyun Li'" <xiaoyun.li@intel.com>,
	"'Alvin Zhang'" <alvinx.zhang@intel.com>,
	"'Shannon Nelson'" <snelson@pensando.io>,
	"'Alfredo Cardigliano'" <cardigliano@ntop.org>,
	"'Vamsi Attunuru'" <vattunuru@marvell.com>,
	"'Yash Sharma'" <ysharma@marvell.com>,
	"'Ivan Malov'" <ivan.malov@oktetlabs.ru>,
	"'Andrew Lee'" <alee@solarflare.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get
Date: Fri, 23 Apr 2021 09:49:40 +0800	[thread overview]
Message-ID: <006401d737e2$ee9c5b80$cbd51280$@trustnetic.com> (raw)
In-Reply-To: <20210421162058.1352960-1-ferruh.yigit@intel.com>

On April 22, 2021 12:21 AM, Ferruh Yigit wrote:
> Fixes a few different things:
> * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is
>   zero, 'fw_version' being NULL but 'fw_size' not zero condition checked
>   in ethdev layer
> * Be sure required buffer size is returned if provided one is not big
>   enough, instead of returning success (0)
> * Document in doxygen comment the '-EINVAL' is a valid return type
> * Take into account that 'snprintf' can return negative value
> * Cast length to 'size_t' to compare it with 'fw_size'
> 
> Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
> Fixes: ff70acdf4299 ("net/axgbe: support reading FW version")
> Fixes: e2652b0a20a0 ("net/bnxt: support get FW version")
> Fixes: cf0fab1d2ca5 ("net/dpaa: support firmware version get API")
> Fixes: 748eccb97cdc ("net/dpaa2: add support for firmware version get")
> Fixes: b883c0644a24 ("net/e1000: add firmware version get")
> Fixes: 293430677e9c ("net/enic: add handler to return firmware version")
> Fixes: 1f5ca0b460cd ("net/hns3: support some device operations")
> Fixes: bd5b86732bc7 ("net/hns3: modify format for firmware version")
> Fixes: ed0dfdd0e976 ("net/i40e: add firmware version get")
> Fixes: e31cb9a36298 ("net/ice: support FW version getting")
> Fixes: 4f09bc55ac3d ("net/igc: implement device base operations")
> Fixes: eec10fb0ce6b ("net/ionic: support FW version")
> Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get")
> Fixes: 4d9f5b8adc02 ("net/octeontx2: add FW version get operation")
> Fixes: f97b56f9f12e ("net/qede: support FW version query")
> Fixes: 83fef46a22b2 ("net/sfc: add callback to retrieve FW version")
> Fixes: bc84ac0fadef ("net/txgbe: support getting FW version")
> Fixes: 21913471202f ("ethdev: add firmware version get")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

<...>

> diff --git a/drivers/net/txgbe/txgbe_ethdev.c
> b/drivers/net/txgbe/txgbe_ethdev.c
> index 97796f040b43..8dbe3da5c2c9 100644
> --- a/drivers/net/txgbe/txgbe_ethdev.c
> +++ b/drivers/net/txgbe/txgbe_ethdev.c
> @@ -2582,9 +2582,11 @@ txgbe_fw_version_get(struct rte_eth_dev *dev,
> char *fw_version, size_t fw_size)
>  	hw->phy.get_fw_version(hw, &etrack_id);
> 
>  	ret = snprintf(fw_version, fw_size, "0x%08x", etrack_id);
> +	if (ret < 0)
> +		return -EINVAL;
> 
>  	ret += 1; /* add the size of '\0' */
> -	if (fw_size < (u32)ret)
> +	if (fw_size < (size_t)ret)
>  		return ret;
>  	else
>  		return 0;

For txgbe,
Acked-by: Jiawen Wu <jiawenwu@trustnetic.com>





  parent reply	other threads:[~2021-04-23  1:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 16:20 Ferruh Yigit
2021-04-21 16:30 ` Ajit Khaparde
2021-04-22  8:53   ` Andrew Rybchenko
2021-04-22 11:44 ` Wang, Haiyue
2021-04-22 17:01 ` [dpdk-dev] [EXT] " Rasesh Mody
2021-04-23  1:49 ` Jiawen Wu [this message]
2021-04-23  2:00 ` [dpdk-dev] " Xing, Beilei
2021-04-23  2:19 ` Jiawen Wu
2021-04-26 12:02   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-23  3:22 ` [dpdk-dev] " Hemant Agrawal
2021-04-28  8:12 ` Yang, Qiming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006401d737e2$ee9c5b80$cbd51280$@trustnetic.com' \
    --to=jiawenwu@trustnetic.com \
    --cc=aboyer@pensando.io \
    --cc=ajit.khaparde@broadcom.com \
    --cc=alee@solarflare.com \
    --cc=alvinx.zhang@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=asomalap@amd.com \
    --cc=beilei.xing@intel.com \
    --cc=cardigliano@ntop.org \
    --cc=chenhao164@huawei.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=fengchunsong@huawei.com \
    --cc=ferruh.yigit@intel.com \
    --cc=haiyue.wang@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=humin29@huawei.com \
    --cc=hyonkim@cisco.com \
    --cc=igor.russkikh@aquantia.com \
    --cc=ivan.malov@oktetlabs.ru \
    --cc=jerinj@marvell.com \
    --cc=jia.guo@intel.com \
    --cc=jianwang@trustnetic.com \
    --cc=jingjing.wu@intel.com \
    --cc=johndale@cisco.com \
    --cc=kirankumark@marvell.com \
    --cc=lihuisong@huawei.com \
    --cc=ndabilpuram@marvell.com \
    --cc=oulijun@huawei.com \
    --cc=pavel.belous@aquantia.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=remy.horton@intel.com \
    --cc=rmody@marvell.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=selwin.sebastian@amd.com \
    --cc=snelson@pensando.io \
    --cc=somnath.kotur@broadcom.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=vattunuru@marvell.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xavier.huwei@huawei.com \
    --cc=xiaoyun.li@intel.com \
    --cc=yisen.zhuang@huawei.com \
    --cc=ysharma@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).