From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45EC443A40; Wed, 7 Feb 2024 11:56:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B63EB40279; Wed, 7 Feb 2024 11:56:57 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41]) by mails.dpdk.org (Postfix) with ESMTP id 7AC084021D for ; Wed, 7 Feb 2024 11:56:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZAlfBsknoqwpv6VvKmjRiwLUy7Qh6DquD4Cz2VTeH9QKSsJkRGDeGeZWipqJboXLK+ElQWvEBEOybOdM8goba64Dx0xp09piWIbjD3p96kD3U41lra10r7sKPzDyriNQL0V9H16Da76ABahoKezAloMUMIUrD3FnlaUPqhHlamZF2ECcKwXVAPXFO4VnO6ISiFDhfbzaU6yhne3a0bHsgkWAg8Dlnu2iM6rcnt235LDD6+z3tqcnD67roycNm1+pp7CbIpOxr+i7rl6tvtcfwnqabaLOM/Ziauo6mhca/rfMLPUJffKmM0K1RwxyuuPYjgU33pQxmN/weUnYRx68QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eVa83Rib3rTL6z3IS06khN5ZJvsd8WurUAOqJCrR2Ow=; b=mD681d4wzu9f1D3EZQ6ftkdHOcPiOEmxleigGsG72UZGxuvYUsyKB9MigkL2o+rO11n9zvaVPL/KBeEu/cGcVDXTUmckHet84N1SN/Htm9ZSWBEeoTeVg8mn+Ffv5q6Qgg6ulBlN6zwh1wL4EekXjNOWlMTSGRDQPY0YNBZxHB5Uti/xtwmMPzrTJfrX5SEXmFAVpY5TTnJf9d+V3yDdedFjPJhwZXP3zn0xqj6BKOHIoaUWWT/wYJOGEd/U5+5Z15YsujeDvRCsHLo9+utiMu+ywY9IZLdNPM7R0dnGNjnzQApq8Co0TiTeEG75vuVJU8yDSnN7qcaAKQZcCvMFWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eVa83Rib3rTL6z3IS06khN5ZJvsd8WurUAOqJCrR2Ow=; b=zHBeqKlCnm/kCeunOL/sHiM+WxZbgbqhLqs+GdLUwqeqjU1iLqEwIaSkOwInpcMvQ3QUnQbYKsqILV5lnE6/1CVGLcpQLkYszmNFpXYFvKPnK3qi9IHynuNnx++fKLoxV+rVJlRfPC58sEdMzXg10Y8XkSW9lo+O8FyvLEuk+so= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB5002.namprd12.prod.outlook.com (2603:10b6:610:6d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.17; Wed, 7 Feb 2024 10:56:54 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.016; Wed, 7 Feb 2024 10:56:54 +0000 Message-ID: <00761c83-1843-420d-aaeb-d9e49329e191@amd.com> Date: Wed, 7 Feb 2024 10:56:49 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ethdev: fast path async flow API Content-Language: en-US From: Ferruh Yigit To: Thomas Monjalon , Dariusz Sosnowski , "Mcnamara, John" Cc: Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Andrew Rybchenko , dev@dpdk.org References: <20240131093523.1553028-1-dsosnowski@nvidia.com> <13882742.RDIVbhacDa@thomas> <2b0c7fe0-5713-4416-987e-34da0dc4aaef@amd.com> <2956397.VdNmn5OnKV@thomas> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0137.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB5002:EE_ X-MS-Office365-Filtering-Correlation-Id: fa0f4ce8-1429-4abf-82e7-08dc27cb7ebc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yGoriU5JwXSskRsd6zsuc2CChDK7MlymeiiMaqsL4gngYcDS2jtJXOfIv5RgOZuLgUVmY9L+mR8pLBIOzexH0AMcp+Fd4MUrSUNc9ZzWDZJ0CsOdKIfEQVLI29u1DkOaEpgQORmeYujjbz5rgj8rn9E8QoYAne46Qqwfz9+AGXa9IAfLHm15EcrDV02yikMyfWCwMawoY0Ntixeffm9UAHjifrTEX7cG3sYkMfVxNPJPr79LyS4AHq2qHp10eGeJHhtM85NYyGX4QIfFHl7mQzkQ2mN3At17QzEfJR2nXUXHZdFOCm9R8xQ1YdSBk6TAZy9U+7BpM97lE2nwiTOmAncKwgA6apBLDuG0bm2qxHBN7Gy+UDma1H/9Fqw/iL5kPAqqTKbWnGytzLXSINLLvyggnPxs5GRYe9l+Cz3r1+HhjpdcdF4IbUwnmtGzSe6tTZ16GSesmNL57tXoLBuZVRIP9FYBCnDokDxKPqZtaYbVh5AZfCP7zCWVhpp5LswIJEp2hFoRQ2BPDxsB4l5peiYVPgan7Z2RXw6RKmBBJ4DvV/208LdzftDLlHZhWlq/XUBqOH1QHFQ9KinH0fbUxHT1kZ820cbzDBPGCW42JDNHu55pIURfS0siY5yGWWgYVP9eIg0VsHlrly7efIZvdQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(346002)(396003)(136003)(366004)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(44832011)(5660300002)(2906002)(316002)(66476007)(54906003)(66556008)(41300700001)(110136005)(8676002)(8936002)(4326008)(66946007)(36756003)(478600001)(86362001)(6666004)(26005)(53546011)(6512007)(6506007)(2616005)(31696002)(83380400001)(6486002)(38100700002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZE5ucVkzNE45YVA4c3RuU1EyU3VBRThySkduRGxQTW5wR09WYkFjOWdHQ3ZF?= =?utf-8?B?aEdreTVDTEZhWFB0WG5aY0RMbWhtU1ZYam5tcW9vSU41cVRtd0tCVUhhcTVF?= =?utf-8?B?NUxlQWUrWU1LbVZIWElYcFFaWkwwRFNOMEFyM1pDZlY2Z2FRUXNnM25YQ2dF?= =?utf-8?B?THIyMGozTTVpaHZjdGMvNnFadXA0Y0Q1cVhLaXF2eitDWlNOdGVqMm0wV2RW?= =?utf-8?B?WTJONjRVMEtlU2tJaXJFanpUbkRDSWhxMnhzS3lINUZ1Q2o1bFZ4MEtieTF0?= =?utf-8?B?Q1M4WGlPbFA5a0FFeG5qaWpRM0hBaEhMRGEvSmxIamp5aE1VSUlJaWZZTVlP?= =?utf-8?B?NXkzSDV4a1dGblB5U2ppT2p0WUg1eEpjUEJUTkMzNlVtUjVQd2NNeG1RYitm?= =?utf-8?B?QkRZSCtzdS9BMEk5WGllelcydUlhaDJqT1RIRnp3aGl1ZGpKL0toS2x0UFlH?= =?utf-8?B?VnBoSzZ5L1JQOGlSUjdseU5ZMk1FWXVadllWL1Jja2lsbGxPMWgxZUFQdFBa?= =?utf-8?B?WDY0cTZxamt1cGwzNHFlQ3VTd1ZhK1VsYUF2TnAwZERmaXdtMG95dkhSNXR5?= =?utf-8?B?ZGhrSkJXdkVlWktoQzR0QmxFVTJCK3JseDI3T3hjcEYwWitzejFuTzJmbThq?= =?utf-8?B?Y0o0UERKcVJzNDNIc1A0VEEzM2UzT1Jib0RKUHdDd1UrVkNuK09zZ0lhUXkv?= =?utf-8?B?MHlXekxhWkdwWXFubFZ3R2FveUZ6L2VhOEJmQmpGcUdURk9JUUZlWE5DcGFq?= =?utf-8?B?TVJVN2lHb1VWcW5WcHZGZlAvdTBPME5ReC9wQ01XSnZ2ZkpvZkZNajVRTUVo?= =?utf-8?B?M0Z6YStpYmFEZUNrM3NMaVZ2ZGNTQXQrUENrZ3RMZ0c2emJaZXVLZmVwaG5K?= =?utf-8?B?YU0xWENQMGJCUGRUN3h0YlRQc0p3VmMvUWRtUHpMUTV3L0dKZHluSDZOWGtN?= =?utf-8?B?RU9TenVvQ0J3T25VNUplc002T2ZTa0k5QkJ0SjZOcmY5SkRQWTNJSGJuNy9i?= =?utf-8?B?M0RoVXFmbHpscmM2NVBsVVoxVVN2SW1PVUptVFAxVlRoSXMvTkx3UmZxazlV?= =?utf-8?B?OWtIWjdNbDZlbFlEOG9EemN2WnBMOEVJNEgrK25WTGZ5TkQzT202Vk5hcFUw?= =?utf-8?B?dnBCYVVkanZYTFdhTklvMTJseEhRRE5tMTZOM1JMbzZnSnFQaEMzMGlFZm0w?= =?utf-8?B?dkp0UXNVV0xyM09oZlVVSXVaNzNmQTNGeUxRdmJvcUYxUXNRV3hTMFQvb2J6?= =?utf-8?B?THJFNWY5TDNGV0ZURHZneDZyaWhWRm5BT2pLWWNHS3duSkNGYXpxNExPTEJz?= =?utf-8?B?dE1xa0RpUDZreTkrcUtPR1NaOXFRVkp2VDJjRGNrTjlydVlEcFZRdTdRU2ZU?= =?utf-8?B?dE5UR294ZmptaWI0TjhEaG5wVWZsN3U1blFnd3Y4NzhWbkNXQ2syMmphTjRq?= =?utf-8?B?RmY2QXBkaEdGNVV5OE5rSmdTejdLZllBRmp4VXk5b0JISmJadDQzSnlZSC8v?= =?utf-8?B?azBDMUhkd3E1aHRpekhqb1dxY0d0SnhrdFRhT3JmNFhubkk5TEg4SDcvZFM5?= =?utf-8?B?ZU4wR090alFndkRHc2V0UUpsbXhYTC82bkI5cldzeU8ra01wQ1dsVXUwWXEw?= =?utf-8?B?MGN4d3QzVnZoUFUwWHhsWm1pSGhOM3RwU2ltTWFnQTZNdDFuSGFnS0pDU05m?= =?utf-8?B?ZXVHczJBY3ZlVVJlMzdwVm04N3pjWjRrRmRxSFR1Qjd5aGVmWWpFSXdsb29N?= =?utf-8?B?Rk43NVdqOVV4K1lNVDVSenZ3ekNaT1psU2Y2RHppdHdUMjVTdEp1MzFlSEVQ?= =?utf-8?B?dXdBU2M4ZnhhUG1lNEUrT3lDcWMwbXo2emM2SzIvWXZNamFTaG1FZ1lORjlY?= =?utf-8?B?ZXZvclpzK1JUVzFLd3I1dnBuKzViQWxqRXdYeHJoZVIrZGU4YXRTRDhBWlUr?= =?utf-8?B?WTk2cjkzUHQ3bzBvOExaa3VJYm84U3V2ZmR6NE5nTW16dXF1d0RBd3N1L0t4?= =?utf-8?B?TlVMQ0g4bC9GSmRjam9vSi9wK0ZDdmxFYUNEOEdYQmxTT3NLaGZTcUp1TFRU?= =?utf-8?B?QmVjR0FnYWkwK3orRVB4MGJVbWxMSCtFa3NsVTNaUG5vZkxZR3FvWCtTaTZL?= =?utf-8?Q?MFACm/A/+HWnm0N7DIqT1Xpdd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa0f4ce8-1429-4abf-82e7-08dc27cb7ebc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 10:56:53.9718 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U05ZDNVrthIoTxmNHjVNHQTTP8s3QtSXgX2iNstH6jL2P7lngokgL6C/LKlMh8bf X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5002 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/7/2024 10:47 AM, Ferruh Yigit wrote: > On 2/7/2024 9:27 AM, Thomas Monjalon wrote: >> 07/02/2024 01:57, Ferruh Yigit: >>> On 2/6/2024 10:21 PM, Thomas Monjalon wrote: >>>> 06/02/2024 18:36, Dariusz Sosnowski: >>>>> --- a/doc/guides/nics/build_and_test.rst >>>>> +++ b/doc/guides/nics/build_and_test.rst >>>>> +- ``RTE_FLOW_DEBUG`` (default **disabled**; enabled automatically on debug builds) >>>>> + >>>>> + Build with debug code in asynchronous flow APIs. >>>>> + >>>>> .. Note:: >>>>> >>>>> - The ethdev library use above options to wrap debug code to trace invalid parameters >>>>> + The ethdev library uses above options to wrap debug code to trace invalid parameters >>>>> on data path APIs, so performance downgrade is expected when enabling those options. >>>>> - Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path. >>>>> + Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path >>>>> + and in asynchronous flow APIs implementation. >>>> >>>> Good >>>> >>>>> --- a/doc/guides/rel_notes/release_24_03.rst >>>>> +++ b/doc/guides/rel_notes/release_24_03.rst >>>>> +* ethdev: PMDs implementing asynchronous flow operations are required to provide relevant functions >>>>> + implementation through ``rte_flow_fp_ops`` struct, instead of ``rte_flow_ops`` struct. >>>>> + Pointer to device-dependent ``rte_flow_fp_ops`` should be provided to ``rte_eth_dev.flow_fp_ops``. >>>> >>>> That's a change only for the driver. >>>> If there is no change for the application, it should not appear in the release notes. >>>> BTW, API means Application Programming Interface :) >>>> >>>>> + This change applies to the following API functions: >>>>> + >>>>> + * ``rte_flow_async_create`` >>>>> + * ``rte_flow_async_create_by_index`` >>>>> + * ``rte_flow_async_actions_update`` >>>>> + * ``rte_flow_async_destroy`` >>>>> + * ``rte_flow_push`` >>>>> + * ``rte_flow_pull`` >>>>> + * ``rte_flow_async_action_handle_create`` >>>>> + * ``rte_flow_async_action_handle_destroy`` >>>>> + * ``rte_flow_async_action_handle_update`` >>>>> + * ``rte_flow_async_action_handle_query`` >>>>> + * ``rte_flow_async_action_handle_query_update`` >>>>> + * ``rte_flow_async_action_list_handle_create`` >>>>> + * ``rte_flow_async_action_list_handle_destroy`` >>>>> + * ``rte_flow_async_action_list_handle_query_update`` >>>>> + >>>>> +* ethdev: Removed the following fields from ``rte_flow_ops`` struct: >>>>> + >>>>> + * ``async_create`` >>>>> + * ``async_create_by_index`` >>>>> + * ``async_actions_update`` >>>>> + * ``async_destroy`` >>>>> + * ``push`` >>>>> + * ``pull`` >>>>> + * ``async_action_handle_create`` >>>>> + * ``async_action_handle_destroy`` >>>>> + * ``async_action_handle_update`` >>>>> + * ``async_action_handle_query`` >>>>> + * ``async_action_handle_query_update`` >>>>> + * ``async_action_list_handle_create`` >>>>> + * ``async_action_list_handle_destroy`` >>>>> + * ``async_action_list_handle_query_update`` >>>> >>>> [...] >>>>> --- a/lib/ethdev/ethdev_driver.h >>>>> +++ b/lib/ethdev/ethdev_driver.h >>>>> @@ -71,6 +71,10 @@ struct rte_eth_dev { >>>>> struct rte_eth_dev_data *data; >>>>> void *process_private; /**< Pointer to per-process device data */ >>>>> const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ >>>>> + /** >>>>> + * Fast path flow API functions exported by PMD. >>>>> + */ >>>> >>>> This comment may be on one single line. >>>> >>>>> + const struct rte_flow_fp_ops *flow_fp_ops; >>>>> struct rte_device *device; /**< Backing device */ >>>>> struct rte_intr_handle *intr_handle; /**< Device interrupt handle */ >>>> >>>>> --- a/lib/ethdev/meson.build >>>>> +++ b/lib/ethdev/meson.build >>>>> +if get_option('buildtype').contains('debug') >>>>> + cflags += ['-DRTE_FLOW_DEBUG'] >>>>> +endif >>>> >>>> This looks OK. >>>> >>>> Acked-by: Thomas Monjalon >>>> >>>> >>> >>> Acked-by: Ferruh Yigit >>> >>> Applied to dpdk-next-net/main, thanks. >> >> Ferruh, I was expecting a new version. >> Did you address yourself the comments above? >> >> > > No, I missed the comment, if it is simple I can apply in next-net, let > me sync with Dariusz. > As we synced with Dariusz, there is no good place to document ethdev-drivers interfaces in the release notes. Also this release there were more ethdev-drivers interface changes, around get_ptype(), but those also not documented in the release notes, so will remove these ones too. But for further release notes, @Thomas, @John, what do you think to add a new section (or sub-section) for "internal interface" ?? (device abstraction - drivers) interface changes?