From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1A36A0567; Wed, 10 Mar 2021 08:58:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8900E22A2E3; Wed, 10 Mar 2021 08:58:52 +0100 (CET) Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) by mails.dpdk.org (Postfix) with ESMTP id EEA3040687 for ; Wed, 10 Mar 2021 08:58:49 +0100 (CET) X-QQ-mid: bizesmtp3t1615363124tpd072g7e Received: from jiawenwu (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Wed, 10 Mar 2021 15:58:44 +0800 (CST) X-QQ-SSF: 01400000002000C0D000B00A0000000 X-QQ-FEAT: YKCDl5A3/aqJ+qwLfcQaKOvVDohpTCqmX1WwQYdeOH+F4CGmvxPRCCPiXVHxY rlLOvrAM+rR7frh6a2kkUuFI1Iwe3F//P1jMlEqs2Q9Wh27cLCamOkmCpL3k96b0N//58xp 99oEpjfiPGkGsFyyQivAGVofpWjhf42VXPxX67mNrhX8Tx4PJkd7wv7d6UVGWhh5etXZwBz lhSu62jcCrZFvLDt/v5ak7tvTevqqiiphl+hU0L6sU+UGtUBx/1222jaqctmrX+pVF/SqeP N+B/ptEl/iY6boJ0E/4R6LMKQMbPlPdLZHg7GXflJahZ91WfNj+sKY9nngiRg//z+jT2LBQ IlR7LZHd/+y+MQRtbtb760KEK5CHQ== X-QQ-GoodBg: 2 From: "Jiawen Wu" To: "'Ferruh Yigit'" , References: <20210305112359.16716-1-jiawenwu@trustnetic.com> <20210305112359.16716-2-jiawenwu@trustnetic.com> In-Reply-To: Date: Wed, 10 Mar 2021 15:58:44 +0800 Message-ID: <007801d71583$318c8230$94a58690$@trustnetic.com>+C83021D3586D4AED MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIBcY8WnTdg3TPuYVozK/16GM/ihwJqT3WDArX8Tcyp/rs3UA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign5 X-QQ-Bgrelay: 1 Subject: Re: [dpdk-dev] [PATCH 1/5] net/txgbe: update device ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday, March 9, 2021 10:25 PM, Ferruh Yigit wrote: > On 3/5/2021 11:23 AM, Jiawen Wu wrote: > > For more different devices, update device ID and subsystem id. > > > > Signed-off-by: Jiawen Wu > > --- > > drivers/net/txgbe/base/txgbe_devids.h | 44 ++++++++++++++------- > > drivers/net/txgbe/base/txgbe_hw.c | 55 = ++++++++++++--------------- > > drivers/net/txgbe/base/txgbe_phy.c | 40 +++++++++++-------- > > drivers/net/txgbe/txgbe_ethdev.c | 4 +- > > drivers/net/txgbe/txgbe_ethdev_vf.c | 4 +- > > 5 files changed, 84 insertions(+), 63 deletions(-) > > > > diff --git a/drivers/net/txgbe/base/txgbe_devids.h > > b/drivers/net/txgbe/base/txgbe_devids.h > > index 744f2f3b5..cb186170e 100644 > > --- a/drivers/net/txgbe/base/txgbe_devids.h > > +++ b/drivers/net/txgbe/base/txgbe_devids.h > > @@ -15,22 +15,40 @@ > > /* > > * Device IDs > > */ > > -#define TXGBE_DEV_ID_RAPTOR_VF 0x1000 > > -#define TXGBE_DEV_ID_RAPTOR_SFP 0x1001 /* fiber */ > > -#define TXGBE_DEV_ID_RAPTOR_KR_KX_KX4 0x1002 /* > backplane */ > > -#define TXGBE_DEV_ID_RAPTOR_XAUI 0x1003 /* copper > */ > > -#define TXGBE_DEV_ID_RAPTOR_SGMII 0x1004 /* copper > */ > > -#define TXGBE_DEV_ID_RAPTOR_QSFP 0x1011 /* fiber */ > > -#define TXGBE_DEV_ID_RAPTOR_VF_HV 0x2000 > > -#define TXGBE_DEV_ID_RAPTOR_T3_LOM 0x2001 > > - > > -#define TXGBE_DEV_ID_WX1820_SFP 0x2001 > > +#define TXGBE_DEV_ID_SP1000 0x1001 > > +#define TXGBE_DEV_ID_WX1820 0x2001 > > +#define TXGBE_DEV_ID_SP1000_VF 0x1000 > > +#define TXGBE_DEV_ID_WX1820_VF 0x2000 > > > > /* > > - * Subdevice IDs > > + * Subsystem IDs > > */ > > -#define TXGBE_SUBDEV_ID_RAPTOR 0x0000 > > -#define TXGBE_SUBDEV_ID_MPW 0x0001 > > +/* SFP */ > > +#define TXGBE_DEV_ID_SP1000_SFP 0x0000 > > +#define TXGBE_DEV_ID_WX1820_SFP 0x2000 > > +#define TXGBE_DEV_ID_SFP 0x00 >=20 > Just for double check, is id '0x0000' valid, from the overall SP/WX = logic it looks > like it should be '0x1000'. >=20 It does have '0x0000' as its subsystem id, by the firmware defined. > > +/* copper */ > > +#define TXGBE_DEV_ID_SP1000_XAUI 0x1010 > > +#define TXGBE_DEV_ID_WX1820_XAUI 0x2010 > > +#define TXGBE_DEV_ID_XAUI 0x10 > > +#define TXGBE_DEV_ID_SP1000_SGMII 0x1020 > > +#define TXGBE_DEV_ID_WX1820_SGMII 0x2020 > > +#define TXGBE_DEV_ID_SGMII 0x20 > > +/* backplane */ > > +#define TXGBE_DEV_ID_SP1000_KR_KX_KX4 0x1030 > > +#define TXGBE_DEV_ID_WX1820_KR_KX_KX4 0x2030 > > +#define TXGBE_DEV_ID_KR_KX_KX4 0x30 > > +/* MAC Interface */ > > +#define TXGBE_DEV_ID_SP1000_MAC_XAUI 0x1040 > > +#define TXGBE_DEV_ID_WX1820_MAC_XAUI 0x2040 > > +#define TXGBE_DEV_ID_MAC_XAUI 0x40 > > +#define TXGBE_DEV_ID_SP1000_MAC_SGMII 0x1060 > > +#define TXGBE_DEV_ID_WX1820_MAC_SGMII 0x2060 > > +#define TXGBE_DEV_ID_MAC_SGMII 0x60 > > +/* combined interface*/ > > +#define TXGBE_DEV_ID_SFI_XAUI 0x50 > > +/* fiber qsfp*/ > > +#define TXGBE_DEV_ID_QSFP 0x11 > > > > #define TXGBE_ETHERTYPE_FLOW_CTRL 0x8808 > > #define TXGBE_ETHERTYPE_IEEE_VLAN 0x8100 /* 802.1q protocol */ > > diff --git a/drivers/net/txgbe/base/txgbe_hw.c > > b/drivers/net/txgbe/base/txgbe_hw.c > > index 3cee8b857..7a3e9510c 100644 > > --- a/drivers/net/txgbe/base/txgbe_hw.c > > +++ b/drivers/net/txgbe/base/txgbe_hw.c > > @@ -60,9 +60,9 @@ bool txgbe_device_supports_autoneg_fc(struct > txgbe_hw *hw) > > break; > > case txgbe_media_type_copper: > > /* only some copper devices support flow control autoneg */ > > - switch (hw->device_id) { > > - case TXGBE_DEV_ID_RAPTOR_XAUI: > > - case TXGBE_DEV_ID_RAPTOR_SGMII: > > + switch (hw->device_id & 0xFF) { > > + case TXGBE_DEV_ID_XAUI: > > + case TXGBE_DEV_ID_SGMII: >=20 > Should this be "hw->subsystem_device_id & 0xFF", instead of = 'hw->device_id' > as has been a few below instances? If the 'hw->device_id' is the pci = device id, > the 'hw->device_id & 0xFF' can be 0 or 1, both don't match the cases = in the > switch. Thanks for the review, it really should be 'hw->subsystem_device_id & = 0xFF'.