From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BFA5C567A for ; Thu, 22 Sep 2016 01:56:00 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 21 Sep 2016 16:55:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,375,1470726000"; d="scan'208";a="11846777" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 21 Sep 2016 16:55:59 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Sep 2016 16:55:59 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.12]) by fmsmsx120.amr.corp.intel.com ([169.254.15.209]) with mapi id 14.03.0248.002; Wed, 21 Sep 2016 16:55:58 -0700 From: "Wiles, Keith" To: Thomas Monjalon CC: "" , Yuanhan Liu , "pmatilai@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface Thread-Index: AQHSEvQv7kxpKvAVnE+1FsoxYSMpO6CDn2WAgAALooCAAGeXgIABBDaA Date: Wed, 21 Sep 2016 23:55:58 +0000 Message-ID: <008395DB-AC42-48DD-AE46-27017BE009FA@intel.com> References: <1473948649-14169-1-git-send-email-keith.wiles@intel.com> <17C91FD1-D21A-49E3-B093-71AA5C1D79C6@intel.com> <20160921021351.GY23158@yliu-dev.sh.intel.com> <4238923.20rfmTZejf@xps13> In-Reply-To: <4238923.20rfmTZejf@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.181.25] Content-Type: text/plain; charset="us-ascii" Content-ID: <82173011D5FFC4419FEC8B087F0C7640@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 23:56:01 -0000 Regards, Keith > On Sep 21, 2016, at 4:24 AM, Thomas Monjalon = wrote: >=20 > 2016-09-21 10:13, Yuanhan Liu: >> On Wed, Sep 21, 2016 at 01:32:15AM +0000, Wiles, Keith wrote: >>> I only assumed this to work for Linux and not FreeBSD/NetBSD as the han= dling of the opens on the tun device are different then linux. I also only = added it to the common_linux configuration file. >>=20 >> I didn't notice the common_linux file, but I have guessed so (that you >> meant to enable linux only): the "ifdef __linux" stuff just confuses me >> a bit. >=20 > By the way, we have a macro for Linux environment: RTE_EXEC_ENV_LINUXAPP > Please prefer it over __linux I removed the __linux__ ifdef in v3, BTW I think we need to grep the code f= or the __linux__ as I started with one of the other drivers. I will try to = remember to grep the drivers when I am back home.